mon: implicit erasure code crush ruleset is not validated #5276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
ghost
pushed a commit
that referenced
this pull request
Jul 19, 2015
…validated Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Jul 19, 2015
…validated Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Jul 19, 2015
…validated Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Jul 19, 2015
…validated Reviewed-by: Loic Dachary <ldachary@redhat.com>
FAIL: test/ceph_objectstore_tool.py
===================================
vstarting.... DONE
Wait for health_ok... DONE
Traceback (most recent call last):
File "./test/ceph_objectstore_tool.py", line 920, in
status = main(sys.argv[1:])
File "./test/ceph_objectstore_tool.py", line 255, in main
REPID = get_pool_id(REP_POOL, nullfd)
File "./test/ceph_objectstore_tool.py", line 45, in get_pool_id
return check_output(cmd, stderr=nullfd).split()[3]
File "/usr/lib64/python2.7/subprocess.py", line 575, in check_output
raise CalledProcessError(retcode, cmd, output=output)
subprocess.CalledProcessError: Command '['./ceph', 'osd', 'pool', 'stats', 'rep_pool']' returned non-zero exit status 2
strange, repeating. |
ghost
changed the title
ceph-mon needs crushtool to be in PATH. Don't set if it is run from ceph_vstart_wrapper, which already sets it as it needs. Signed-off-by: Mykola Golub <mgolub@mirantis.com> (cherry picked from commit e08bccf)
We want to fix the following scenario: * an erasure code plugin (or another part of the code) creates a ruleset * the ruleset crashes during mapping (for whatever reason) * ceph osd pool create uses the bugous ruleset * the monitors try to do mapping a crash Having a bugous ruleset in the crush map is very difficult prevent. The catastrophic event of using it with a newly created pool can however be prevented by calling the CrushTester just before creating the pool and after all implicit or explicit crush ruleset creation happened. http://tracker.ceph.com/issues/11814 Fixes: #11814 Signed-off-by: Loic Dachary <ldachary@redhat.com> (cherry picked from commit f1e86be) Conflicts: src/test/mon/osd-crush.sh removed the run_mon because in hammer it is shared between all tests src/mon/OSDMonitor.cc prepare_new_pool changed stringstream to *ostream
ghost
changed the title
ghost
pushed a commit
that referenced
this pull request
Aug 31, 2015
…validated Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Sep 1, 2015
…validated Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Sep 2, 2015
…validated Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
pass rados suite http://tracker.ceph.com/issues/12701#note-62 |
ghost
pushed a commit
that referenced
this pull request
Sep 6, 2015
implicit erasure code crush ruleset is not validated Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
merged commit
ghost
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/11824