mon: fix crush testing for new pools #6192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit aa238e5) Conflicts: src/crush/CrushTester.cc in hammer the crushtool validation is via a shell and not via an internal subprocess utility src/tools/crushtool.cc ceph_argparse_withint is preferred to ceph_argparse_witharg
ghost
self-assigned this
Otherwise, we test *all* crush rules.. which might be a lot, and which is a big waste of time and effort. Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit 524b0bd) Conflicts: src/mon/OSDMonitor.cc : trivial resolution
Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit 1b3090d) Conflicts: src/mon/OSDMonitor.cc hammer has a separate error message for EINTR which is in the context of the fix for error message
http://tracker.ceph.com/issues/13182 Fixes: #13182 Signed-off-by: Loic Dachary <ldachary@redhat.com> (cherry picked from commit 21a1e75) Conflicts: qa/workunits/cephtool/test.sh the test structure in hammer is different, adapt the relevant test.
If there are a lot of crush rules (say, 100) then the test can take a long time. 100 values per rule should be enough to catch most issues. Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit 0f82f46) Conflicts: src/crush/CrushTester.cc in hammer the crushtool validation is via a shell and not via an internal subprocess utility
|
lgtm |
|
passes make check manually, will run one of the failed job 20 times to verify |
ghost
pushed a commit
that referenced
this pull request
Oct 7, 2015
mon: fix crush testing for new pools Reviewed-by: Sage Weil <sage@redhat.com>
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/13401