New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fs: ceph-fuse 0.94.2-1trusty segfaults / aborts #5381
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cache_cb We drop the lock when invoking the callback, which means the directory we're looking at might get dentries trimmed out of memory. Make sure that hasn't happened after we get the lock back. If it *has* happened, fall back to requesting the directory contents from the MDS. Update the dirp location pointers after each entry to facilitate this. Because this requires we update the dirp->at_cache_name value on every loop, we rework the updating scheme a bit: to dereference the dn->name before unlocking, so we know it's filled in; and since we update it on every loop we don't need to refer to the previous dentry explicitly like we did before. This should also handle racing file deletes: we get back a trace on the removed dentry and that will clear the COMPLETE|ORDERED flags. Fixes #12297 Signed-off-by: Greg Farnum <gfarnum@redhat.com> (cherry picked from commit 62dd637)
ghost
pushed a commit
that referenced
this pull request
Jul 29, 2015
ghost
pushed a commit
that referenced
this pull request
Aug 30, 2015
Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 30, 2015
Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 30, 2015
Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ukernel this backport passed the CephFS suite (http://pulpito.ceph.com/loic-2015-08-15_22:10:39-fs-hammer-backports---basic-multi/ and http://pulpito.ceph.com/loic-2015-08-19_18:14:42-fs-hammer-backports---basic-multi/), do you think it can be merged ? |
ghost
pushed a commit
that referenced
this pull request
Aug 31, 2015
Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Sep 1, 2015
Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Sep 2, 2015
Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ukernel ping ? |
This looks fine @dachary. |
ghost
pushed a commit
that referenced
this pull request
Sep 9, 2015
ceph-fuse 0.94.2-1trusty segfaults / aborts Reviewed-by: Greg Farnum <gfarnum@redhat.com>
ghost
changed the title
ceph-fuse 0.94.2-1trusty segfaults / aborts
fs: ceph-fuse 0.94.2-1trusty segfaults / aborts
Sep 13, 2015
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/12499