common: LibCephFS.GetPoolId failure #5887
Merged
+16
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we may create a CephContext without calling common_init_finish(), then delete the CephContext. In this case, ceph::crypto:init() is not called, so CephContext::~CephContext() should not call ceph::crypto::shutdown(). Fixes: ceph#12598 Signed-off-by: Yan, Zheng <zyan@redhat.com> (cherry picked from commit 98a85ec)
|
in gitbuilders as wip-pr-5887 |
ghost
pushed a commit
that referenced
this pull request
Oct 2, 2015
Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Oct 3, 2015
Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Oct 3, 2015
Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Oct 3, 2015
Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
@liewegas it passes the rados suite ( http://pulpito.ceph.com/loic-2015-10-03_11:11:28-rados-wip-pr-5887---basic-multi and http://pulpito.ceph.com/loic-2015-10-04_15:14:57-rados-wip-pr-5887---basic-multi are a clean run, except for one failure that was fixed by #6172) and it also passed the two CephFS jobs that consistently fail if it is not applied (http://pulpito.ceph.com/loic-2015-10-03_10:10:17-fs-wip-pr-5887---basic-multi/). Do you think it is good to merge ? This is needed for v0.94.4 and I'll update the draft release notes accordingly. |
liewegas
added a commit
that referenced
this pull request
Oct 6, 2015
LibCephFS.GetPoolId failure Reviewed-by: Sage Weil <sage@redhat.com>
ghost
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/13044