Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: ceph tell: broken error message / misleading hinting #5371

Merged
2 commits merged into from Aug 30, 2015
Merged

cli: ceph tell: broken error message / misleading hinting #5371

2 commits merged into from Aug 30, 2015

Conversation

ghost
Copy link

@ghost ghost commented Jul 28, 2015

* we do not allow user specify a certain daemon when starting an
  interactive session. the existing error message could lead to
  some confusion. so put more details in it.

Fixes: #11101
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 972dc91)
put the full signature of "tell <target> <command> [options...]"
instead of "tell {0}.<id>", which could be misleading somehow.

Fixes: 11101
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit aa1a522)
@ghost ghost self-assigned this Jul 28, 2015
@ghost ghost added this to the hammer milestone Jul 28, 2015
@ghost ghost added bug-fix core labels Jul 28, 2015
ghost pushed a commit that referenced this pull request Jul 29, 2015
@ghost
Copy link
Author

ghost commented Aug 30, 2015

Pass http://tracker.ceph.com/issues/12701#ceph-deploy http://tracker.ceph.com/issues/12701#upgrade (there are job failures but they are unrelated to packaging)

ghost pushed a commit that referenced this pull request Aug 30, 2015
ceph tell: broken error message / misleading hinting

Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost ghost merged commit 4675971 into ceph:hammer Aug 30, 2015
@ghost ghost changed the title ceph tell: broken error message / misleading hinting cli: ceph tell: broken error message / misleading hinting Sep 13, 2015
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants