build/ops: ceph.spec.in: running fdupes unnecessarily #5223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In openSUSE there is a policy to use %fdupes in the spec file if RPMLINT complains about duplicate files wasting space in the filesystem. However, RPMLINT is not so complaining, so drop fdupes. http://tracker.ceph.com/issues/12301 Fixes: ceph#12301 Signed-off-by: Nathan Cutler <ncutler@suse.com> (cherry picked from commit 53072b9)
|
second occurrence of this false negative in two days. If that frequency is confirmed I'll backport the necessary changes. |
ghost
changed the title
|
@ktdreyer And in hammer, too? |
ktdreyer
added a commit
that referenced
this pull request
Sep 4, 2015
ceph.spec.in: running fdupes unnecessarily Reviewed-by: Ken Dreyer <kdreyer@redhat.com>
|
Thanks! |
ghost
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/12305