New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build/ops: ceph.spec.in: ceph-common needs python-argparse on older distros, but doesn't require it #5216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
ceph-common needs python-argparse on older distros, but doesn't require it
ceph.spec.in: ceph-common needs python-argparse on older distros, but doesn't require it
Jul 15, 2015
@smithfarm could you please rebase and remove the DNM when you did ? |
ghost
changed the title
ceph.spec.in: ceph-common needs python-argparse on older distros, but doesn't require it
DNM: ceph.spec.in: ceph-common needs python-argparse on older distros, but doesn't require it
Jul 15, 2015
smithfarm
force-pushed
the
wip-12269-hammer
branch
from
July 16, 2015 07:39
09acb6f
to
7620a9e
Compare
argparse is a widely-used Python module for parsing command-line arguments. Ceph makes heavy use of Python scripts, both in the build environment and on cluster nodes and clients. Until Python 2.6, argparse was distributed separately from Python proper. As of 2.7 it is part of the Python standard library. Although the python package in a given distro may or may not Provide: python-argparse, this cannot be relied upon. Therefore, this commit puts appropriate conditionals around Requires: python-argparse and BuildRequires: python-argparse. It does so for Red Hat/CentOS and SUSE only, because the last Fedora version with Python 2.6 was Fedora 13, which is EOL. argparse is required by both the ceph and ceph-common packages, but since ceph requires ceph-common, the argparse Requires and BuildRequires need only appear once, under ceph-common. http://tracker.ceph.com/issues/12034 Fixes: ceph#12034 Signed-off-by: Nathan Cutler <ncutler@suse.com> (cherry picked from commit 23171c9)
smithfarm
force-pushed
the
wip-12269-hammer
branch
from
July 16, 2015 07:41
7620a9e
to
8b576bd
Compare
smithfarm
changed the title
DNM: ceph.spec.in: ceph-common needs python-argparse on older distros, but doesn't require it
ceph.spec.in: ceph-common needs python-argparse on older distros, but doesn't require it
Jul 16, 2015
@dachary OK, done. |
Pass http://tracker.ceph.com/issues/12701#ceph-deploy http://tracker.ceph.com/issues/12701#upgrade (there are job failures but they are unrelated to packaging) |
ghost
pushed a commit
that referenced
this pull request
Aug 30, 2015
ceph.spec.in: ceph-common needs python-argparse on older distros, but doesn't require it Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
changed the title
ceph.spec.in: ceph-common needs python-argparse on older distros, but doesn't require it
build/ops: ceph.spec.in: ceph-common needs python-argparse on older distros, but doesn't require it
Sep 13, 2015
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/12269