Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding message option to the import subcommand #15711

Merged
merged 1 commit into from Aug 26, 2015

Conversation

monitorjbl
Copy link
Contributor

Fixes #15710

@calavera
Copy link
Contributor

@monitorjbl this is going to need integration tests under integration-cli and documentation.

@monitorjbl
Copy link
Contributor Author

Sure thing, I just wanted to see verification jobs passed. They didn't, but I'm not sure if it was something I added or not.

@cpuguy83
Copy link
Member

+1 test and we can get this in quickly.
Thanks!

@monitorjbl
Copy link
Contributor Author

Sorry, I was at a conference this past weekend. I'll get tests added as soon as I can!

@monitorjbl monitorjbl force-pushed the import-commit-message branch 3 times, most recently from a6c4347 to 3893e10 Compare August 25, 2015 00:31
Signed-off-by: Taylor Jones <monitorjbl@gmail.com>
@calavera
Copy link
Contributor

Thanks @monitorjbl, changes LGTM. I think you still need to add this flag to the man pages under man. But we should move this forward to docs review as soon as other maintainers give their lgtm.

@monitorjbl
Copy link
Contributor Author

Whoops, forgot about the man page. I'll get that updated too.

@monitorjbl monitorjbl force-pushed the import-commit-message branch 2 times, most recently from f6d87bf to 936b2c6 Compare August 25, 2015 13:36
@monitorjbl
Copy link
Contributor Author

Added this option to the manpage for docker-import

@cpuguy83
Copy link
Member

LGTM, failures are unrelated.
Moving to docs review.

@thaJeztah
Copy link
Member

docs LGTM, thanks!

@SvenDowideit
Copy link
Contributor

Docs LGTM - @calavera are you doing the merging?

calavera added a commit that referenced this pull request Aug 26, 2015
adding message option to the import subcommand
@calavera calavera merged commit b857dad into moby:master Aug 26, 2015
@monitorjbl
Copy link
Contributor Author

Awesome, thanks guys!

docker-jenkins pushed a commit to docker/docker-ce that referenced this pull request Jan 2, 2020
This parameter was introduced 4 years ago in b857dad
as part of moby/moby#15711, but has never made it to the API docs.

Signed-off-by: Jan Chren (rindeal) <dev.rindeal@gmail.com>
Upstream-commit: 9608dc5470e74f1ee34fd6477547303b31868576
Component: engine
thaJeztah pushed a commit to thaJeztah/docker that referenced this pull request Jan 17, 2020
This parameter was introduced 4 years ago in b857dad
as part of moby#15711, but has never made it to the API docs.

Signed-off-by: Jan Chren (rindeal) <dev.rindeal@gmail.com>
(cherry picked from commit 9608dc5)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins pushed a commit to docker/docker-ce that referenced this pull request Jan 23, 2020
This parameter was introduced 4 years ago in b857dad
as part of moby/moby#15711, but has never made it to the API docs.

Signed-off-by: Jan Chren (rindeal) <dev.rindeal@gmail.com>
(cherry picked from commit 9608dc5470e74f1ee34fd6477547303b31868576)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Upstream-commit: ea5f540fb62632b448b286d22eca41a3956a75a2
Component: engine
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants