Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transformations such as scale, translate, rotate won't be incorrectly affected by the layout #832

Merged
merged 1 commit into from Sep 28, 2015

Conversation

PanayotCankov
Copy link
Contributor

In iOS we now set bound along the frame property on the native views.

The easiest way to reproduce this is to display an UI similar to:

<GridLayout width="50" height="50">
    <Image src="res://img" rotate="25" backgroundColor="red" />
</GridLayout>

The image will be rotated but will also somewhat scale since the transform was not reapplied after the frame was set. After applying this fix, the image will appear correctly rotated.

@PanayotCankov PanayotCankov self-assigned this Sep 28, 2015
@PanayotCankov PanayotCankov added this to the 1.4.0 milestone Sep 28, 2015
@ns-bot ns-bot added cla: yes and removed cla: no labels Sep 28, 2015
@ns-bot
Copy link

ns-bot commented Sep 28, 2015

Test FAILed.

@hshristov
Copy link
Contributor

run ci

@ns-bot
Copy link

ns-bot commented Sep 28, 2015

Test PASSed.

@hshristov
Copy link
Contributor

👍

PanayotCankov added a commit that referenced this pull request Sep 28, 2015
Transformations such as scale, translate, rotate won't be incorrectly affected by the layout
@PanayotCankov PanayotCankov merged commit 0be5a71 into master Sep 28, 2015
@PanayotCankov PanayotCankov deleted the layout-invalidates-transform branch September 28, 2015 13:05
@lock
Copy link

lock bot commented Aug 29, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants