This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
Use last-ditch manifest parser for error reporting #1471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a great start, but I'm wondering if we can make the message a bit more helpful (e.g. maybe showing the current rkt's appc version?) Paging @robszumski if he has any time to advise.. |
|
What about something like this? |
We usually don't use this style. Also, in one line we did not return any value, so a default integer value was returned instead (as the return variable was not set to anything, so it defaulted to 0). This meant returning 0 even if we could not get ACI infos. Also removed the same from pod list command.
This replaces a tabOut global variable with a function that sets up a new tab writer consistently, but allows caller to customize the backing io.Writer. In later commits, the `rkt image list` and `rkt list` commands will change the backing writer to the bytes buffer to ensure that the list is written after all the errors.
Simply put value in an array and join it later with tab as a separator.
GetImageManifestJSON returns the manifest as bytes to be parsed. So if this function returns an error, it means that the image was actually removed. GetImageManifest might return an error in two cases - either the image was removed or its manifest was invalid. The GetImageManifestJSON will be used in rkt image list.
|
Current output of And current output of |
| }) | ||
| uuid = "" | ||
| state = "" | ||
| nets = "" |
There was a problem hiding this comment.
Can you make uuid, state, nets variables local to the for loop so that you don't have to clear them?
There was a problem hiding this comment.
I'll add a comment here then. It is cleared after first iteration, so subsequent iterations get empty values.
|
Current output of (Added the |
| lines = append(lines, " Also, failed to get any information about invalid image manifest:") | ||
| lines = append(lines, fmt.Sprintf(" %v", imErr)) | ||
| } | ||
| lines = append(lines, "ID of the invalid image:") |
There was a problem hiding this comment.
Missing two space to indent "Id of the invalid image:"
|
LGTM if green. Thanks! |
krnowak
added a commit
that referenced
this pull request
Sep 28, 2015
Use last-ditch manifest parser for error reporting
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Text below copied from #1266.
Example output of
rkt list: