This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
rkt: exit with status 1 on image rm failure #1486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@blixtra I think we can squash the commits into one as it's a small patch. |
|
Well, semaphore is not green. seems in pod_manifest_test, it fails to rm images. |
|
@yifan-gu I think there's a problem in that test. I'll look into it. |
|
That test is failing because it was doing a However, I'd suggest we wait till #1240 is merged. That change makes it so that |
|
#1240 is merged now |
blixtra
force-pushed
the
blixtra/rkt-image-rm-exit-status
branch
from
19d31df
to
620a96e
Compare
|
ping |
If `rkt image rm` is not able to remove one or more of the images it should exit with a status 1.
The "Multiple apps" was using the exact same image to run the test but expecting different hashes to be returned. Because the same hash was being returned and a `rkt image rm` command was being issued for each hash, the second attempt to remove the image was failing. This change applies a simple name patch to each image to force a unique hash.
blixtra
force-pushed
the
blixtra/rkt-image-rm-exit-status
branch
from
620a96e
to
feaa5ed
Compare
|
@jonboulle pong ;-) This should pass. |
|
thanks! |
jonboulle
added a commit
that referenced
this pull request
Oct 2, 2015
rkt: exit with status 1 on image rm failure
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
rkt image rmcannot remove one or more of the images that it is passed, it should return an exit status of 1. Up to now an exit status of 0 has been returned whether all, some or no images could be removed.Closes #1483