This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
Godeps: bump appc to 0.7.1 and goaci #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LFAD. |
|
Tests fail because they take more than the current timeout (20min) and they get killed. We should do something about TestFetch, it takes more than 7 minutes (more than 10 on my computer): #1544 |
They were getting killed because they took more than the current timeout (20m). We should optimize the running time of the tests (especially TestFetch) but in the meantime we increase the timeout to 30m.
|
I increased the timeout to 30m so we can test while #1544 is not fixed. |
iaguis
added a commit
that referenced
this pull request
Oct 6, 2015
Godeps: bump appc to 0.7.1 and goaci
alban
added a commit
to alban/rkt
that referenced
this pull request
Oct 23, 2015
rkt uses appc/spec 0.7.1 since rkt#1543
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
appc/spec v0.7.1 was released. Unfortunately, the tag was not pushed but I assumed it will point to appc/spec@818ac4d and updated the Godeps accordingly.
I modified manually Godeps.json so the
Commentfield saysv0.7.1instead ofv0.7.0-24-g818ac4d. This is just a comment so it causes no problems and it will be accurate when the tag is pushed.