This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
lkvm: make sure $HOME is defined before running lkvm #1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As we are using rkt only from root account (privileges needed by network setup) - it LGTM. |
| @@ -136,7 +136,7 @@ bind: No such file or directory | |||
| Warning: Failed init: kvm_ipc__init | |||
| ``` | |||
|
|
|||
| The LKVM stage1 currently requires $HOME to be defined | |||
| The LKVM stage1 currently requires $HOME to be defined and valid | |||
| (see [issue #1393](https://github.com/coreos/rkt/issues/1393)). | |||
| When started from a systemd unit file, use `User=root`. | |||
There was a problem hiding this comment.
did you mean to remove these lines?
There was a problem hiding this comment.
I am undecided whether to keep that paragraph. I decided to keep it just in case the user mistakenly starts rkt with $HOME=/nonexistent-dir or something... but that's not very plausible so I'm ok to remove these lines if you prefer.
There was a problem hiding this comment.
Ack, I think it's clearer if we just remove them for now.
|
LGTM modulo one question |
kvmtool currently does not work when $HOME is not defined. When started by a systemd unit file (or by systemd-run), $HOME is typically undefined, unless "User=" (or resp. "--uid=") is given. Instead of asking users to work around the issue with "User=" or "--uid=", just define that variable in rkt before calling lkvm. This could be removed when this gets fixed in lkvm upstream. Issue described in rkt#1393
alban
force-pushed
the
alban/lkvm-home-dir4
branch
from
83f94ca
to
c43be2e
Compare
|
LGTM |
iaguis
added a commit
that referenced
this pull request
Sep 23, 2015
lkvm: make sure $HOME is defined before running lkvm
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kvmtool currently does not work when $HOME is not defined. When started
by a systemd unit file (or by systemd-run), $HOME is typically
undefined, unless "User=" (or resp. "--uid=") is given.
Instead of asking users to work around the issue with "User=" or
"--uid=", just define that variable in rkt before calling lkvm.
This could be removed when this gets fixed in lkvm upstream.
Issue described in #1393
/cc @jellonek