This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
stage0: added exec flag to prepare statement #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When preparing a container, the exec flag can be used to override the default binary run inside the container. Behaves the same way as on the run command.
|
This should solve #1395 |
|
@dgonyeo Could you add a functional test for this to tests/rkt_exec_test.go please? |
|
LGTM |
| } | ||
| } | ||
|
|
||
| func runRktAndGetUUID(t *testing.T, rktCmd string) string { |
There was a problem hiding this comment.
would you mind splitting this into a shared file (rkt_tests.go perhaps) and using it in the pod manifest test too, now? Can do that in a follow up if you like
|
A couple of nits but LGTM after that, thanks! |
added 2 commits
September 17, 2015 12:25
Added a new test to make sure that the --exec flag on the prepare command works as intended.
Moved runRktAndGetUUID to tests/rkt_tests.go, and modified TestPodManifest to use it. Reduces code duplication.
|
nits resolved |
|
👍 , merge on green |
cgonyeo
pushed a commit
that referenced
this pull request
Sep 17, 2015
stage0: added exec flag to prepare statement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When preparing a container, the exec flag can be used to override the
default binary run inside the container. Behaves the same way as on the
run command.