This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
provide more info in rkt list #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the rkt documentation the image hash was by and large referred to as the image ID. However, in the rkt subcommands key was often used. This change tries to make the use of "image ID" consistant across user-facing elements of rkt.
The `rkt list` command currently shows an inadequate amount of information to determine which image an app is associated with. For example, one could have fetched multiple versions of an image and it's possible for images to have the same name but different hashes. However, these details are not shown in the output. This change adds the version information to the default `rkt list` output and adds the 12-char ID of the image to the output when the '--full' flag is used. It also changes the 'ACI' field header to 'IMAGE NAME'. Closes rkt#1492
|
lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rkt listcommand currently shows an inadequate amount of information to determine which image an app is associated with. For example, one could have fetched multiple versions of an image and it's possible for images to have the same name but different hashes. However, these details are not shown in the output.This change adds the version information to the default
rkt listoutput and adds the 12-char ID of the image to the output when the '--full' flag is used.It also changes the 'ACI' field header to 'IMAGE NAME'.
Lastly, this PR change tries to make the term used for the image's hash value more consistent by changing the user-facing reference to "Image ID" instead of "key". "Key" is already used more adequately in the trust context.
Closes #1492