Prevent data loss when exporting a file as an existing directory #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! New version soon. |
prikhi
added a commit
that referenced
this pull request
Sep 21, 2015
Prevent data loss when exporting a file as an existing directory
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #576 and #459.
When a file (eg. PDF) is exported with the destination path of an existing directory, the directory is destroyed and the file is not created. Although the exporter uses the correct dialog window (file/directory) when
Browseis clicked, the user is able to manually modify the destination path in the text field, thus necessitating extra validation.This fix ensures that if the destination path exists, that it is the correct type (file or directory) required by the selected export type.
Tested on Mac and Windows.