Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dartdoc.bat has a wrong variable expansion and fails to run dartdoc #24252

Closed
dynaxis opened this issue Sep 1, 2015 · 6 comments
Closed

dartdoc.bat has a wrong variable expansion and fails to run dartdoc #24252

dynaxis opened this issue Sep 1, 2015 · 6 comments
Assignees
@keertip
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures
Milestone
1.12.1

Comments

@dynaxis
Copy link

dynaxis commented Sep 1, 2015

https://github.com/dart-lang/sdk/blob/1.12.0/sdk/bin/dartdoc.bat#L17

In the referenced line, $BIN_DIR should have been %BIN_DIR%. Due to this issue, dartdoc.bat won't run dartdoc properly.
@sethladd sethladd added the P1 A high priority bug; for example, a single project is unusable or has many test failures label Sep 1, 2015
@sethladd
Copy link
Contributor

sethladd commented Sep 1, 2015

Sorry about that. Thanks for filing!

@keertip @whesse is there a way our Windows bots can run this and other .bat files during a build, to test they are correct?

cc @mit-mit

@mit-mit mit-mit mentioned this issue Sep 1, 2015
Closed
4 tasks
@keertip
Copy link
Contributor

keertip commented Sep 1, 2015

Thanks for the report!

@keertip
Copy link
Contributor

keertip commented Sep 1, 2015

fixed in https://codereview.chromium.org/1318603006/

@keertip keertip closed this as completed Sep 1, 2015
@sethladd
Copy link
Contributor

sethladd commented Sep 1, 2015

Can we roll this out in a 1.12.1 release? @keertip can we file a MergeToStable which I guess means MergeToPreviousReleaseBranch ?

@sethladd sethladd reopened this Sep 1, 2015
@sethladd sethladd added this to the 1.12.1 milestone Sep 1, 2015
@keertip keertip mentioned this issue Sep 1, 2015
Closed
@keertip
Copy link
Contributor

keertip commented Sep 1, 2015

Was just filing the issue! #24265

@sethladd
Copy link
Contributor

sethladd commented Sep 1, 2015

Was just filing the issue!

You 🎸

@sethladd sethladd closed this as completed Sep 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keertip keertip

Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Milestone
1.12.1
Development

No branches or pull requests
4 participants
@sethladd @dynaxis @keertip @mit-mit