This repository has been archived by the owner on Apr 13, 2022. It is now read-only.
ngJq causes warning in Firefox #12741
Comments
gkalpak
added a commit
to gkalpak/angular.js
that referenced
this issue
Sep 3, 2015
Previously, even when `ng-jq` was empty (which should force the use of jqLite), Angular tried to find jQuery on `window['']`. If it didn't find anything there, it would fall back to jqLite (as expected). Nonetheless, trying to access `window['']` calls `getElementById('')`, which issues a warning in Firefox (maybe others). This fix properly detects when `ng-jq` is empty and avoids trying to access `window['']`. Fixes angular#12741
gkalpak
added a commit
to gkalpak/angular.js
that referenced
this issue
Sep 3, 2015
Previously, even when `ng-jq` was empty (which should force the use of jqLite), Angular tried to find jQuery on `window['']`. If it didn't find anything there, it would fall back to jqLite (as expected). Nonetheless, trying to access `window['']` calls `getElementById('')`, which issues a warning in Firefox (maybe others). This fix properly detects when `ng-jq` is empty and avoids trying to access `window['']`. Fixes angular#12741
gkalpak
added a commit
to gkalpak/angular.js
that referenced
this issue
Sep 3, 2015
Previously, even when `ng-jq` was empty (which should force the use of jqLite), Angular tried to find jQuery on `window['']`. If it didn't find anything there, it would fall back to jqLite (as expected). Nonetheless, trying to access `window['']` calls `getElementById('')`, which issues a warning in Firefox (maybe others). This fix properly detects when `ng-jq` is empty and avoids trying to access `window['']`. Fixes angular#12741
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
If ngJq is used without a value passed to it Firefox warns "Empty string passed to getElementById()."
Tested in Firefox 40.0.3.
http://jsbin.com/kimatejiqa/1/edit?html,js,output
The text was updated successfully, but these errors were encountered: