fix($parse): assign returns the new value

The `.assign` function returns the new value. The version with csp enabled already has this behavior. Closes #12675 Closes #12708
angular · Aug 31, 2015 · 7d2c6ee · 7d2c6ee
1 parent 6d8c195
commit 7d2c6ee
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/src/ng/parse.js b/src/ng/parse.js
@@ -774,6 +774,7 @@ ASTCompiler.prototype = {
       this.state.computing = 'assign';
       var result = this.nextId();
       this.recurse(assignable, result);
+      this.return_(result);
       extra = 'fn.assign=' + this.generateFunction('assign', 's,v,l');
     }
     var toWatch = getInputs(ast.body);

diff --git a/test/ng/parseSpec.js b/test/ng/parseSpec.js
@@ -2797,6 +2797,14 @@ describe('parser', function() {
           expect(scope).toEqual({a:123});
         }));
 
+        it('should return the assigned value', inject(function($parse) {
+          var fn = $parse('a');
+          var scope = {};
+          expect(fn.assign(scope, 123)).toBe(123);
+          var someObject = {};
+          expect(fn.assign(scope, someObject)).toBe(someObject);
+        }));
+
         it('should expose working assignment function for expressions ending with brackets', inject(function($parse) {
           var fn = $parse('a.b["c"]');
           expect(fn.assign).toBeTruthy();