Infinite digest on location change on iOS 9 w/ UIWebView (not in Safari/ WKWebView) #12241

ttopalov · 2015-06-30T11:46:03Z

The following simple HTML demonstrates the issue:

<!DOCTYPE html>
<html>
    <head>
        <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.3.16/angular.js"></script>
        <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.3.16/angular-route.js"></script>
        <script>
            angular.module('fail', ['ngRoute'])
            .config(function($routeProvider) {
                $routeProvider
                .when('/a', {
                    template: '<a ng-href="#/b">a</a>'
                })
                .when('/b', {
                    template: '<a ng-href="#/a">b</a>'
                })
                .otherwise({
                    redirectTo: '/a'
                });
            });
        </script>
    </head>
    <body ng-app="fail">
        <div ng-view></div>
    </body>
</html>

This runs as expected on most devices, but it throws an infinite digest exception on iOS 9.
I'm able to reproduce on both iPad Air 2 and iPad 4th generation with iOS 9 beta 2.
I realize it's probably an issue in iOS, but it might still be worth investigating.

cxm01 · 2015-07-01T08:11:44Z

I met similar issue, which happened on ios 9, but run ok on other devices.

cxm01 · 2015-07-02T03:23:38Z

I reproduced this issue with the same code provided by santaslow on 1.4.1 / ios 9:

<!DOCTYPE html>
<html>
<head>
    <script src="../static/js/angular/angular.1.4.1.js"></script>
    <script src="../static/js/angular-route/angular-route.1.4.1.js"></script>
    <script>
        angular.module('fail', ['ngRoute'])
                .config(function ($routeProvider) {
                    $routeProvider
                            .when('/a', {
                                template: '<a ng-href="#/b">a</a>'
                            })
                            .when('/b', {
                                template: '<a ng-href="#/a">b</a>'
                            })
                            .otherwise({
                                redirectTo: '/a'
                            });
                }).factory('$exceptionHandler', ['$log', function($log) {
                    return function(exception, cause) {
                        var message = 'angularjs exception: '+exception.message+': caused by "' + cause+ '\njs stack:\n'+exception.stack;
                        $log.error(message);
                    };
                }]);
    </script>
</head>
<body ng-app="fail">
<div ng-view></div>
</body>
</html>

The code above run normally on desktop browser, android and ios 8 webview, but on ios 9 it will throw exception when I click the link:

2015-07-02 11:00:09 ... angularjs exception: [$rootScope:infdig] 10 $digest() iterations reached. Aborting!
Watchers fired in the last 5 iterations: []
http://errors.angularjs.org/1.4.1/$rootScope/infdig?p0=10&p1=%5B%5D: caused by "undefined
js stack:
file:///.../static/js/angular/angular.js:68:32
$digest@file:///.../static/js/angular/angular.js:15705:35
$apply@file:///.../static/js/angular/angular.js:15935:31
file:///.../static/js/angular/angular.js:12070:30
eventHandler@file:///.../static/js/angular/angular.js:3264:25

ttopalov · 2015-07-09T14:43:43Z

I can no longer reproduce in iOS 9 Beta 3.

aexei · 2015-07-11T20:16:11Z

I receive the same error with ios9 public beta (13A4293g)

cxm01 · 2015-07-13T02:17:14Z

I verified the code above on ios 9 beta 3 (13A4293g), no exception anymore. But the app with using ng-view still throw infdig exceptions on ios 9 beta 3.

arkomr · 2015-07-13T03:26:15Z

I receive the same error with ios9 public beta (13A4293g)

Error: [$rootScope:infdig] 10 $digest() iterations reached. Aborting!
Watchers fired in the last 5 iterations: []
http://errors.angularjs.org/1.3.13/$rootScope/infdig?p0=10&p1=%5B%5D
file:///Users/mac5/Library/Developer/CoreSimulator/Devices/749DE7E3-D93F-47F9-A1FC-E3D54A1CCEEE/data/Containers/Bundle/Application/9B5EE368-F2A0-4C99-807B-EA17B2479E58/BAShops.app/www/lib/ionic/js/ionic.bundle.js:8762:32
$digest@file:///Users/mac5/Library/Developer/CoreSimulator/Devices/749DE7E3-D93F-47F9-A1FC-E3D54A1CCEEE/data/Containers/Bundle/Application/9B5EE368-F2A0-4C99-807B-EA17B2479E58/BAShops.app/www/lib/ionic/js/ionic.bundle.js:22980:35
$apply@file:///Users/mac5/Library/Developer/CoreSimulator/Devices/749DE7E3-D93F-47F9-A1FC-E3D54A1CCEEE/data/Containers/Bundle/Application/9B5EE368-F2A0-4C99-807B-EA17B2479E58/BAShops.app/www/lib/ionic/js/ionic.bundle.js:23205:31
file:///Users/mac5/Library/Developer/CoreSimulator/Devices/749DE7E3-D93F-47F9-A1FC-E3D54A1CCEEE/data/Containers/Bundle/Application/9B5EE368-F2A0-4C99-807B-EA17B2479E58/BAShops.app/www/lib/ionic/js/ionic.bundle.js:54879:24
eventHandler@file:///Users/mac5/Library/Developer/CoreSimulator/Devices/749DE7E3-D93F-47F9-A1FC-E3D54A1CCEEE/data/Containers/Bundle/Application/9B5EE368-F2A0-4C99-807B-EA17B2479E58/BAShops.app/www/lib/ionic/js/ionic.bundle.js:11713:25
dispatchEvent@[native code]
triggerMouseEvent@file:///Users/mac5/Library/Developer/CoreSimulator/Devices/749DE7E3-D93F-47F9-A1FC-E3D54A1CCEEE/data/Containers/Bundle/Application/9B5EE368-F2A0-4C99-807B-EA17B2479E58/BAShops.app/www/lib/ionic/js/ionic.bundle.js:2863:20
tapClick@file:///Users/mac5/Library/Developer/CoreSimulator/Devices/749DE7E3-D93F-47F9-A1FC-E3D54A1CCEEE/data/Containers/Bundle/Application/9B5EE368-F2A0-4C99-807B-EA17B2479E58/BAShops.app/www/lib/ionic/js/ionic.bundle.js:2852:20
tapTouchEnd@file:///Users/mac5/Library/Developer/CoreSimulator/Devices/749DE7E3-D93F-47F9-A1FC-E3D54A1CCEEE/data/Containers/Bundle/Application/9B5EE368-F2A0-4C99-807B-EA17B2479E58/BAShops.app/www/lib/ionic/js/ionic.bundle.js:2975:13

epaga · 2015-07-15T07:23:49Z

We are also receiving this error on public Beta 3 of iOS 9 with our own Angular application. It does not occur in iOS 8.

cxm01 · 2015-07-15T07:56:40Z

As a workaround, I wrote a simple directive to replace ng-view and angular-route.js. The solution worked well in our own application, all infdig exceptions disappeared on ios 9 beta/beta 3. Below is the simplified code, which is just for our own application, general use cases are not considered. I DO NOT recommend other people to use this:

(function (window) {
    'use strict';

    var myApp = angular.module("myApp");
    var $route = {};

    // replace $routeProvider.when with the function below:
    window.routeWhen = function(path, route) {
        $route[path] = route;
    };

    myApp.directive("myView", ['$compile', '$controller', '$http', '$rootScope', function ($compile, $controller, $http, $rootScope) {

        return {
            priority: -400,
            link: function (scope, element) {
                var parentScope = scope;
                scope = null;

                window.updateView = function (path) {
                    location.hash = '#'+url;
                    if (scope) scope.$destroy();
                    scope = parentScope.$new();

                    var route = $route[path];

                    var linkView = function(html) {
                        element.html(html);
                        var link = $compile(element.contents());
                        var controller = $controller(route.controller, {$scope: scope});
                        element.data('$ngControllerController', controller);
                        element.children().data('$ngControllerController', controller);
                        link(scope);
                        scope.$emit('$viewContentLoaded');
                        if (!$rootScope.$$phase && !scope.$$phase) scope.$apply();
                    };
                    if (route.templateCache) linkView(route.templateCache)
                    else if (route.template) {
                        route.templateCache = document.getElementById(route.template).innerHTML;
                        linkView(route.templateCache)
                    }
                    else $http.get(route.templateUrl;).success(function(html) {
                        route.templateCache = html;
                        linkView(html);
                    });
                };
                //updateView(initialPath);
                // call updateView(path) to set location at other places of the app
            }
        };
    }]);

})(window)

raftheunis87 · 2015-07-22T06:24:56Z

Just installed iOS 9 Beta 4 and still have the same issue. Anyone else?

craig-at-rsg · 2015-07-22T13:57:57Z

I saw it in iOS 9 Beta 3 and I'm still seeing it in iOS 9 Beta 4.

aexei · 2015-07-22T14:03:03Z

+1

vincentdu101 · 2015-07-28T22:44:53Z

Yeah we're seeing the same issue as well even with angular ui router. Does anybody have a valid work around for this issue in the meantime?

viattik · 2015-07-31T11:25:36Z

Seeing the same issue in uiWebView on latest iOS9.

raftheunis87 · 2015-08-03T05:40:54Z

Does anyone have any updates on this issue?

lgalfaso · 2015-08-03T14:33:51Z

This is still an issue. Reopening

Narretz · 2015-08-03T23:05:41Z

It looks like an ios issue. Is this tracked on webkit somewhere?

mike1e · 2015-08-04T18:55:16Z

+1

RolfDeVries · 2015-08-05T08:23:33Z

+1

borrull · 2015-08-05T08:29:16Z

Same here. Our Cordova app runs fine if running as web on the iPad Safari, but the infinite digest happens if it runs as a Cordova app (UIWebView).

raftheunis87 · 2015-08-05T08:46:42Z

Exactly the same issues as @borrull ! Already experimented with WKWebView and then the issue is non-existing. But we can't use WKWebView as we need Local File Serving (and we don't want to run a local server in our application) and cookies. So it has to do something with UIWebView in combination with Cordova/Mobile Safari on iOS 9. I'm currently debugging the $locationWatch in Angular because I see that our application wants to transition to a different location multiple times and then (after 10 times) the digest error is thrown.

alexislg2 · 2015-09-17T22:09:43Z

Does released 1.4.6 fix this issue for good?

petebacondarwin · 2015-09-18T05:15:54Z

@alexislg2 - yes this release should fix the issue so you do not need to apply the patch.

dbroadhurst · 2015-09-18T05:50:40Z

Confirmed, works for me on the simulator and device, just need my users to wait 2 weeks for Apple approval ;-(

petebacondarwin · 2015-09-18T10:42:07Z

@dbroadhurst I heard you might be able to quote the https://openradar.appspot.com/22186109 bug report to fast track your update to your app.

hober · 2015-09-21T22:29:37Z

You can follow this WebKit bug for updates.

lchenneberg · 2015-09-25T00:51:52Z

Hi, you seem to have solved the issue of iOS9 async call on hash change on Angular.js.

I've made researches, also posted on stackoverflow but the only solution I found until now is in your angular browser.js patch.

I'm not really familiar with angular and I would like to understand what you did make you fix available in
every web application based on Hash Routing

Would you explain how you identified and fixed the problem?

http://stackoverflow.com/questions/32719631/how-to-fix-window-location-issue-in-ios9-uiwebview?noredirect=1#comment53359668_32719631

petebacondarwin · 2015-09-25T12:07:01Z

@lchenneberg - the commit that fixes the problem in AngularJS is here 8d39bd8

The problem is that this particular browser does not update the value for window.location.href until the next run of the JavaScript event loop. This means that if you write to that value then immediately read it back you get a different value:

console.log(window.location.href)   // -> http://my.domain.com/path/to/page
window.location.href = 'http://my.domain.com/path/to/other/page';
console.log(window.location.href)   // -> http://my.domain.com/path/to/page

// next tick of the event loop

console.log(window.location.href)   // -> http://my.domain.com/path/to/other/page

Notice that the second console.log returns the old value, not the new value. After the current event loop completes, the value is updated, as can be seen in the third console.log

The fix that we have come up with, is to cache the value that we wrote, if the browser is not updating synchronously, and then to use that value from then on, instead of the value returned from window.location.href, until there is a hashchange event, which tells us that the browser has finally sorted itself out.

Hope that helps.

jasdeepsingh · 2015-09-30T07:06:49Z

@IgorMinar 's patch worked well for me. I'm using the following versions of Angular & Ionic:

window.ionic.version "1.0.1"

angular.version
Object {full: "1.3.13", major: 1, minor: 3, dot: 13, codeName: "meticulous-riffleshuffle"}

tpeiffer · 2015-10-01T13:42:25Z

@IgorMinar's patch worked for us as well. Thanks!!

But I have another question one of you may be able to answer:

does launching a web page added to the iPad home screen open the page using UIWebView or WKWebView?

Or, more importantly, does accessing a web application in this way take advantage of the Nitro rendering engine?

mhartington · 2015-10-01T13:46:05Z

@tpeiffer they would use wkwebview, since it's just safari without the address bar.

tzamora · 2015-10-01T23:31:19Z

Hi, I have this exact same issue with an old version of angular: 1.0.6
I see that all the fixes are for newer versions, do you know where should I be looking to see if I can fix this problem? Thanks.

petebacondarwin · 2015-10-02T08:20:18Z

@tzamora Have you tried applying @IgorMinar's patch? Perhaps 1.0.6 is too early for it to work.

tzamora · 2015-10-02T15:24:09Z

@petebacondarwin the @IgorMinar's patch refers to a file called browser.js. I dont have any file called browser.js

hober · 2015-10-02T17:06:11Z

FYI, a fix for the underlying issue landed in WebKit the other day:
http://trac.webkit.org/changeset/190092
http://trac.webkit.org/changeset/190100

var1ableX · 2015-10-04T23:36:53Z

I got this working with the js patch, but not straight away. New to this (angularjs and Ionic) so if someone could check this and let me know if I've missed anything major I'd really appreciate it! (e.g. is the platform object very inefficient etc)

Note:

I downloaded the ios9-$browser-patch.js local
I found that it didn't solve my problem, but forcing isIOS9UIWebView to return true, worked great
I rewrote the patch check using Ionic platform methods, which works fine now. (I've left the old code commented here to show the evolution)

function isIOS9UIWebView(userAgent) {
      return (/9\.[0-9]\.[0-9]/.test(ionic.Platform.version()) && /iOS/.test(ionic.Platform.device() ));

      //return true;
      //return (navigator.userAgent.indexOf(' OS 9') != -1) && (navigator.appVersion.indexOf(' OS 9') != -1);
      //return /(iPhone|iPad|iPod).* OS 9_\d/.test(userAgent) && !/Version\/9\./.test(userAgent);
      // only provide the patch for iOS9 on UIWebView
    }

scott-phillips-sp · 2015-10-06T12:58:13Z

I ran into this problem on 8.4 on the simulator; so I don't think it's limited to just iOS 9. I just updated the agent string check to include versions iOS 8 & 9. Here's the agent string.

"Mozilla/5.0 (iPhone; CPU iPhone OS 8_4 like Mac OS X) AppleWebKit/600.1.4 (KHTML, like Gecko) Mobile/12H141 (140307121489296)"

StevenStar · 2015-10-20T09:20:06Z

+1

FreudGit · 2015-11-11T13:45:07Z

Hi

Can someone confirm if this was solved on ios 9.2? (beta)

Thanks :)

mrowles · 2015-12-09T23:09:01Z

I cannot replicate the issue as of this mornings update to iOS 9.2 (13C75) on iPhone 6. Looking good so far. This bug is still open though - https://openradar.appspot.com/22186109

kthxboosty · 2015-12-21T11:47:47Z

If this patch is applied, could it have any negative effect on iOS 9.2 and up? I will test this with our own app, but I want to make sure I'm not introducing issues that don't show when testing our particular situation.

As far as I can see, all the patches use a regex that filters iOS 9 and up, but not specifically 9.x up to and including 9.1.

ghost · 2015-12-21T14:07:01Z

Hey guys, this issue is currently happening in iPhone 6 with iOS 9, can anyone let me know why?
https://forum.ionicframework.com/t/ios-9-beta-slide-menu-app-transition-issue/30768
is another patch that I need to apply? Please let me know, I really need to fix that screen overlap issue.

brechtcs · 2015-12-21T14:59:32Z

Updating to iOS 9.2 seems to solve it for me too.

lgalfaso · 2015-12-21T15:32:29Z

@bruno-serfe this is an issue on how iOS handles window.location that is present only in iOS 9.0.x. If you can update to Angular 1.4.6+, then there is nothing else you have to do as this version contains the fix. If you cannot upgrade, then the patch at #12241 (comment) has the same fix.

As stated before, this issue is present only in iOS 9.0.x as this was fixed in iOS 9.1.0.

The issue posted on ionic looks like the same issue, so the same fix should work both ways.

ghost · 2015-12-21T16:30:07Z

@lgalfaso thanks for the reply, I'll try to fix a digest error I've found, if that doesn't solve the issue I'll try upgrading angular, thanks for the reply!.

mrowles · 2015-12-22T03:53:27Z

Thanks @lgalfaso 👍

tjespe · 2016-01-30T10:13:24Z

I had this problem when I added the web app to home screen and used it as standalone, however upgrading from AngularJS 1.4.5 to 1.5 completely solved the problem and speeded up the navigation as hell!

raftheunis87 · 2016-03-15T10:31:50Z

@volgwfang The issue that you're having is not related to this topic?

ttopalov closed this as completed Jul 9, 2015

aexei mentioned this issue Jul 15, 2015

bug: infdig Infinite $digest Loop ionic-team/ionic-framework#4082

Closed

viattik mentioned this issue Aug 3, 2015

Infinite digest on location change on iOS 9 beta 4 #12485

Closed

lgalfaso reopened this Aug 3, 2015

Narretz added type: bug component: $location browser: iOS labels Aug 3, 2015

Narretz added this to the Backlog milestone Aug 3, 2015

Narretz modified the milestones: Ice Box, Backlog Aug 3, 2015

petebacondarwin closed this as completed in 8d39bd8 Sep 14, 2015

mhartington mentioned this issue Oct 13, 2015

Async location updates causes flickers #13080

Closed

mishe mentioned this issue Dec 27, 2016

IOS9.0+中hash值的bug与解决方案（转） mishe/blog#149

Open

Infinite digest on location change on iOS 9 w/ UIWebView (not in Safari/ WKWebView) #12241

Infinite digest on location change on iOS 9 w/ UIWebView (not in Safari/ WKWebView) #12241

Comments

ttopalov commented Jun 30, 2015

cxm01 commented Jul 1, 2015

cxm01 commented Jul 2, 2015

ttopalov commented Jul 9, 2015

aexei commented Jul 11, 2015

cxm01 commented Jul 13, 2015

arkomr commented Jul 13, 2015

epaga commented Jul 15, 2015

cxm01 commented Jul 15, 2015

raftheunis87 commented Jul 22, 2015

craig-at-rsg commented Jul 22, 2015

aexei commented Jul 22, 2015 via email

vincentdu101 commented Jul 28, 2015

viattik commented Jul 31, 2015

raftheunis87 commented Aug 3, 2015

lgalfaso commented Aug 3, 2015

Narretz commented Aug 3, 2015

mike1e commented Aug 4, 2015

RolfDeVries commented Aug 5, 2015

borrull commented Aug 5, 2015

raftheunis87 commented Aug 5, 2015

alexislg2 commented Sep 17, 2015

petebacondarwin commented Sep 18, 2015

dbroadhurst commented Sep 18, 2015

petebacondarwin commented Sep 18, 2015

hober commented Sep 21, 2015

lchenneberg commented Sep 25, 2015

petebacondarwin commented Sep 25, 2015

jasdeepsingh commented Sep 30, 2015

tpeiffer commented Oct 1, 2015

mhartington commented Oct 1, 2015

tzamora commented Oct 1, 2015

petebacondarwin commented Oct 2, 2015

tzamora commented Oct 2, 2015

hober commented Oct 2, 2015

var1ableX commented Oct 4, 2015

scott-phillips-sp commented Oct 6, 2015

StevenStar commented Oct 20, 2015

FreudGit commented Nov 11, 2015

mrowles commented Dec 9, 2015

kthxboosty commented Dec 21, 2015

ghost commented Dec 21, 2015

brechtcs commented Dec 21, 2015

lgalfaso commented Dec 21, 2015

ghost commented Dec 21, 2015

mrowles commented Dec 22, 2015

tjespe commented Jan 30, 2016

raftheunis87 commented Mar 15, 2016