fix($animate): invalid CSS class names should not break subsequent elements #12725
Conversation
|
Here is the Plunker showing the issue with the fixed version of Angular: http://plnkr.co/edit/Zux7ICpKvsh6oa25vlzr?p=preview |
petebacondarwin
force-pushed
the
issue-12674
branch
from
9bacf0c
to
1cf35d5
Compare
|
The diff looks more complicated than it is. I pulled two functions, This means that we are not having to recreate them on every call and also makes the |
|
Without the refactor, it would be easier to see what actually changed semantically, though ;) |
|
LGTM. Excellent work. |
|
@Narrate you're right. I should have made two commits |
|
Here is the plunker with the most recent fix: http://plnkr.co/edit/ppS7j623Wz4DifRRBjtu?p=preview |
petebacondarwin
force-pushed
the
issue-12674
branch
from
1cf35d5
to
f1a1f0c
Compare
|
@Narretz - there I have broken the PR into two commits. |
|
@petebacondarwin I almost don't dare to say it, but ... it's actually |
|
Doh! |
|
@Narretz shouldn't you be asleep? |
…ements The postDigest handler was not being added if the first element in to modify the CSS classes contained invalid CSS class names. This meant that subsequent valid CSS class changes were not being handled since we were not then adding the handler for those correct cases. Closes angular#12674
petebacondarwin
force-pushed
the
issue-12674
branch
from
f1a1f0c
to
94a241d
Compare
The postDigest handler was not being added if the first element in
to modify the CSS classes contained invalid CSS class names. This meant
that subsequent valid CSS class changes were not being handled since we
were not then adding the handler for those correct cases.
Closes #12674