Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc_lint: handle more method calls in unconditional_recursion. #26783

Merged
merged 2 commits into from Aug 4, 2015

Conversation

eddyb
Copy link
Member

@eddyb eddyb commented Jul 5, 2015

After #26694, the overloaded operator and "impl not known at method lookup time" cases started triggering the lint.
I've also added checks for overloaded autoderef and method calls via paths (i.e. T::method()).
All new 8 test cases did not trigger the lint before #26694.
r? @huonw

@bors
Copy link
Contributor

bors commented Jul 6, 2015

☔ The latest upstream changes (presumably #26757) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Contributor

bors commented Jul 17, 2015

☔ The latest upstream changes (presumably #27066) made this pull request unmergeable. Please resolve the merge conflicts.

@Gankra
Copy link
Contributor

Gankra commented Jul 27, 2015

ping @huonw (also needs rebase)

bcx.fcx.param_substs))
def::DefMethod(meth_did) => {
let method_item = bcx.tcx().impl_or_trait_item(meth_did);
fn_callee(bcx, match method_item.container() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move the match to a temporary variable (i.e. to not be inline in the function call)?

@huonw
Copy link
Member

huonw commented Jul 30, 2015

r=me with a rebase and the nit.

@eddyb
Copy link
Member Author

eddyb commented Aug 3, 2015

@bors r=huonw

@bors
Copy link
Contributor

bors commented Aug 3, 2015

📌 Commit 585f0e9 has been approved by huonw

bors added a commit that referenced this pull request Aug 3, 2015
After #26694, the overloaded operator and "impl not known at method lookup time" cases started triggering the lint.
I've also added checks for overloaded autoderef and method calls via paths (i.e. `T::method()`).
All new 8 test cases did not trigger the lint before #26694.
r? @huonw
@bors
Copy link
Contributor

bors commented Aug 3, 2015

⌛ Testing commit 585f0e9 with merge 3851794...

@bors bors merged commit 585f0e9 into rust-lang:master Aug 4, 2015
@arielb1 arielb1 mentioned this pull request Sep 15, 2015
@eddyb eddyb deleted the methrec branch March 9, 2017 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants