Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature-gate #[prelude_import]. #26699

Merged
merged 1 commit into from Jul 7, 2015
Merged

Feature-gate #[prelude_import]. #26699

merged 1 commit into from Jul 7, 2015

Conversation

eddyb
Copy link
Member

@eddyb eddyb commented Jul 1, 2015

Closes #26690.

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@eddyb eddyb force-pushed the unstable-prelude_import branch 2 times, most recently from eea540f to 0caedc3 Compare July 1, 2015 03:06
@alexcrichton
Copy link
Member

cc @huonw, you seem pretty familiar with the allow_internal_unstable stuff.

This may also be good to run through Crater first just to double check, but I'd also be fine just going ahead and merging this and covering it in one of the regular "regressions against beta" reports.

Also, nominating for a beta backport.

@alexcrichton alexcrichton added beta-nominated Nominated for backporting to the compiler in the beta channel. T-lang Relevant to the language team, which will review and decide on the PR/issue. labels Jul 1, 2015
huonw
huonw reviewed Jul 1, 2015
View reviewed changes
src/libsyntax/std_inject.rs
}
};
let expn_id = sess.codemap().record_expansion(info);
let mut sp = sp;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be Span { expn_id: expn_id, .. sp }?

@huonw
Copy link
Member

huonw commented Jul 1, 2015

r=me with an passing crater run.

@steveklabnik
Copy link
Member

/cc @brson, can we get a crater run on this?

@brson
Copy link
Contributor

brson commented Jul 6, 2015

I will start now.

@brson
Copy link
Contributor

brson commented Jul 6, 2015

Crater says all good.

@alexcrichton
Copy link
Member

@bors: r=huonw 6a3b385

@bors
Copy link
Contributor

bors commented Jul 7, 2015

⌛ Testing commit 6a3b385 with merge ed14593...

bors added a commit that referenced this pull request Jul 7, 2015
@bors
Auto merge of #26699 - eddyb:unstable-prelude_import, r=huonw
ed14593 
Closes #26690.
@bors
Copy link
Contributor

bors commented Jul 7, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt

@bors bors merged commit 6a3b385 into rust-lang:master Jul 7, 2015
@eddyb eddyb deleted the unstable-prelude_import branch July 7, 2015 18:02
@brson brson added the regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. label Jul 10, 2015
@brson
Copy link
Contributor

brson commented Jul 29, 2015

Not accepted for backport. People aren't using this and we can break it at will. Bugfix.

@brson brson added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-accepted Accepted for backporting to the compiler in the beta channel. beta-nominated Nominated for backporting to the compiler in the beta channel. labels Jul 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@eddyb @rust-highfive @alexcrichton @huonw @steveklabnik @brson @bors