Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate why Tab completion is slow in Git SDK on a domain-joined computer #377

Closed
dscho opened this issue Sep 11, 2015 · 3 comments · Fixed by msys2/MSYS2-packages#343
Closed

Investigate why Tab completion is slow in Git SDK on a domain-joined computer #377

dscho opened this issue Sep 11, 2015 · 3 comments · Fixed by msys2/MSYS2-packages#343
Assignees
@dscho
Labels
enhancement sdk-packages

Comments

@dscho
Copy link
Member

dscho commented Sep 11, 2015

This happens not with all, but with some tab completions, and only on the domain-joined of my machines.
@dscho dscho self-assigned this Sep 11, 2015
@dscho
Copy link
Member Author

dscho commented Sep 11, 2015

A-ha! This StackOverflow comment describes the problem, the culprit and the work-around.

dscho added a commit to dscho/MSYS2-packages that referenced this issue Sep 11, 2015
@dscho
WIP: bash-completion: avoid unnecessary tilde expansion
59ba1a1 
When connected to an Active Directory (a variant of LDAP), tab completion
becomes very slow because the tilde is expanded all the time, even if
completing paths that do not contain a tilde at all. This developer
observed delays of several seconds at a time.

This is completely unnecessary, so let's do not do that.

The patch was provided by Ove Risberg with a bug report to the original
bash-completion project:

	https://bugs.launchpad.net/ubuntu/+source/bash-completion/+bug/1390061

This fixes git-for-windows/git#377

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho
Copy link
Member Author

dscho commented Sep 11, 2015

Work in progress.

dscho added a commit to dscho/MSYS2-packages that referenced this issue Sep 11, 2015
@dscho
bash-completion: avoid unnecessary tilde expansion
ec3da11 
When connected to an Active Directory (a variant of LDAP), tab completion
becomes very slow because the tilde is expanded all the time, even if
completing paths that do not contain a tilde at all. This developer
observed delays of several seconds at a time.

This is completely unnecessary, so let's do not do that.

The patch was provided by Ove Risberg with a bug report to the original
bash-completion project:

	https://bugs.launchpad.net/ubuntu/+source/bash-completion/+bug/1390061

Since it fixes code introduced by another add-on patch, that add-on patch
was modified instead of adding yet another patch.

This fixes git-for-windows/git#377

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho dscho mentioned this issue Sep 11, 2015
Merged
@dscho
Copy link
Member Author

dscho commented Sep 11, 2015

This ticket should be closed automatically when msys2/MSYS2-packages#343 gets merged.

dscho added a commit to dscho/build-extra that referenced this issue Sep 12, 2015
@dscho
WIP
0f0c908 
git-for-windows/git#377
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
jeffhostetler pushed a commit to jeffhostetler/git that referenced this issue Jun 21, 2021
@derrickstolee
Merge pull request git-for-windows#377: Update README to include Scal…
57eeed4 
…ar CLI details

I created these as `fixup!` commits so they get squashed in the next major release rebase, but also so they can be reviewed commit-by-commit.

* The first is a doozy, adjusting line widths and otherwise updating some minor things here and there.
* The rest are small and explained by the body of the commit messages.
* One non-`fixup!` commit adds the `docs/` directory from `microsoft/scalar`, with some edits due to the C port of Scalar.
jeffhostetler pushed a commit to jeffhostetler/git that referenced this issue Aug 18, 2021
@derrickstolee
Merge pull request git-for-windows#377: Update README to include Scal…
8f3ebdc 
…ar CLI details

I created these as `fixup!` commits so they get squashed in the next major release rebase, but also so they can be reviewed commit-by-commit.

* The first is a doozy, adjusting line widths and otherwise updating some minor things here and there.
* The rest are small and explained by the body of the commit messages.
* One non-`fixup!` commit adds the `docs/` directory from `microsoft/scalar`, with some edits due to the C port of Scalar.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dscho dscho

Labels
enhancement sdk-packages
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bash-completion: avoid unnecessary tilde expansion dscho/MSYS2-packages
1 participant
@dscho