Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: remove mSpanInUse count loop from STW #11484

Closed
aclements opened this issue Jun 30, 2015 · 2 comments
Closed

runtime: remove mSpanInUse count loop from STW #11484

aclements opened this issue Jun 30, 2015 · 2 comments
Labels
FrozenDueToAge
Milestone
Go1.6Early

Comments

@aclements
Copy link
Member

On multi-gigabyte heaps, about half of our mark termination time (~5ms of ~10ms at 4GB) is spent in the loop in gcSweep that counts how many spans are mSpanInUse. We should fix this for 1.6. One possible solution is simply to keep track of the number of spans in this state. We could also probably move the loop out of STW, but it seems easier to just keep the count.

@RLH
@aclements aclements added this to the Go1.6Early milestone Jun 30, 2015
@aclements
Copy link
Member Author

See issue #11485 for most of the other half of mark termination time.

@aclements aclements mentioned this issue Jun 30, 2015
Closed
@aclements aclements mentioned this issue Aug 1, 2015
Open
@gopherbot
Copy link

CL https://golang.org/cl/15070 mentions this issue.

@golang golang locked and limited conversation to collaborators Oct 4, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.6Early
Development

No branches or pull requests
2 participants
@aclements @gopherbot