feat(router): improve nginx status page #4290
Conversation
|
This is a screenshot from one of the nginx
|
|
@aledbf i could hug you right now. As part of my metrics spike I was actually parsing the nginx log stream to get these stats which is a terrible and brittle way to get that information. With this I can actually hit 👍 |
| @@ -63,6 +63,9 @@ get_src 501f299abdb81b992a980bda182e5de5a4b2b3e275fbf72ee34dd7ae84c4b679 \ | |||
| get_src 8d280fc083420afb41dbe10df9a8ceec98f1d391bd2caa42ebae67d5bc9295d8 \ | |||
| "https://github.com/openresty/set-misc-nginx-module/archive/v$VERSION_SETMISC.tar.gz" | |||
|
|
|||
| get_src 47340cf0c711b10a0231fca9264d73ea791ff8420b823b0295ae3df2d968a205 \ | |||
| "https://github.com/vozlt/nginx-module-vts/archive/22c51e201a550bb94e96239fef541347beb4eeca.tar.gz" | |||
There was a problem hiding this comment.
Is there a fix we need here that isn't in a specific release? We generally prefer that to SHAs.
There was a problem hiding this comment.
@carmstrong the only reason to use the commit and not a release is because in the last ones there's a fix for the counters and layout of the html
There was a problem hiding this comment.
👍 I think that's fine, then. Could we add a comment with that info above that line?
aledbf
force-pushed
the
improve-nginx-status
branch
from
f42a43b
to
b284dc2
Compare
|
Code LGTM. And FWIW, @jchauncey has never given me a hug before. |
|
code LGTM. |
feat(router): improve nginx status page
Replace the default status page with one that provides more details using the nginx-module-vts module.
By default
/statusreturns html but is possible to get a json representation using the/status/format/jsonpath