New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix memory leaks #194
Fix memory leaks #194
Conversation
wow, that was fast! I'll push it up to our server tomorrow and check it out. |
Hello, I tried the provided binary from https://www.dropbox.com/s/0gd9tnf3qw7ieeo/gor_fix_memory_leaks_x64.tar.gz?dl=1 and it still leaks. On my load it's 1.7 Gb in 3 minutes:
Gor is started as |
It took a bit longer, but results are great :) Number of spawned goroutines dropped in order of magnitude, and it should work way more stable and faster. /cc @chunacatsunflower @Kooper thanks for the feedback! (binaries are updated) |
@buger, the new version has awesome performance indeed! It is even much faster then 0.9.8 - truly amazing. I'm able to replicate up to 800 RPS of HTTP traffic from raw socket (approx. 2MB/s of incoming traffic) without significant CPU load. Thank you for this! Memory leak, however is not fixed completely. With the input volume I have a 100MB/hour increase in memory consumption:
|
Released in v0.10.1 |
It was happening because of time goroutine, and timer was not stopping as well.
Binaries:
https://www.dropbox.com/s/0gd9tnf3qw7ieeo/gor_fix_memory_leaks_x64.tar.gz?dl=1
https://www.dropbox.com/s/nvrakek2vm42pnk/gor_fix_memory_leaks_x86.tar.gz?dl=1