installer: shorten text wrap for terminal captions #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This at least partly addresses the same issue as #70. |
|
Yep. How detailed should the Windows version be? "Windows 8.1" or more detailed? |
|
@charlesrgould detailed enough so I can quickly start the correct VM and test for myself... ;-) |
|
But actually, I can reproduce the issue on Windows Server 2012 R2, so all is good. Testing your patch now (still, it would be nice if you could update the commit message as indicated). |
The wizard page for choosing your terminal emulator for Git truncated some words, e.g. "window" became "wind" and "as" was hidden completely. This was seen on Windows 8.1 and Windows Server 2012 R2. Signed-off-by: Charles Gould <charles.r.gould@gmail.com>
|
@dscho - Done, rebased as well, just... because. |
dscho
added a commit
that referenced
this pull request
Aug 20, 2015
…mulator-captions installer: shorten text wrap for terminal captions
|
Perfect, thank you very much! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wizard page for choosing your terminal emulator truncates some words. See examples in the screenshot below (I am using Windows 8.1, 1920x1080, not sure it matters):
Would this work? I haven't tried building a new installer and running it. Will give it a try if needed.