Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing error messages fixes #4657

Closed
larkost opened this issue Aug 11, 2015 · 1 comment
Closed

testing error messages fixes #4657

larkost opened this issue Aug 11, 2015 · 1 comment
Assignees
Milestone

Comments

@larkost
Copy link
Collaborator

larkost commented Aug 11, 2015

I found that there were some issues with the endings on error messages with them sometime ending in . and sometime ending in :. This turned out to be a lot to work out, but not so many changes in the test infrastructure. The one exception is that the ruby test "driver" needed a bit of modification as it was missing mis-matches on error messages.

This is already done, and this is mostly for tracking purposes. This does bring a few bugs to light that will need to be filed (tomorrow probably).

larkost added a commit that referenced this issue Aug 11, 2015
branch: larkost/4657-test-messages
change review: 3141
larkost added a commit that referenced this issue Aug 11, 2015
branch: larkost/4657-test-messages
change review: 3141
@larkost larkost self-assigned this Aug 11, 2015
@larkost
Copy link
Collaborator Author

larkost commented Aug 11, 2015

This has been merged into next with b14c9d6 and v2.1.x with ca70848.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants