Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix forEach javadoc #3079

Merged
merged 1 commit into from Jul 23, 2015
Merged

fix forEach javadoc #3079

merged 1 commit into from Jul 23, 2015

Conversation

davidmoten
Copy link
Collaborator

Observable.forEach javadoc suffered from a bit of copy-and-paste and neglected to mention the possible throw of OnErrorNotImplementedException.

Also added a couple of unit tests.

@akarnokd
Copy link
Member

Thanks.

akarnokd added a commit that referenced this pull request Jul 23, 2015
@akarnokd
Merge pull request #3079 from davidmoten/foreach-javadoc
afbd89a 
fix forEach javadoc
@akarnokd akarnokd merged commit afbd89a into ReactiveX:1.x Jul 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidmoten @akarnokd