Multiple Outputs Mark II #107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparrc
added a commit
that referenced
this pull request
Aug 12, 2015
sparrc
added a commit
that referenced
this pull request
Aug 12, 2015
sparrc
added a commit
that referenced
this pull request
Aug 12, 2015
sparrc
added a commit
that referenced
this pull request
Aug 12, 2015
|
I'm cool with the breaking change. Sad we have to make it, but everyone will be better for it :) |
|
Good thought on adding I made a few attempts to not make it such a breaking change but couldn't ever settle on a config format that didn't seem like magic. |
sparrc
added a commit
that referenced
this pull request
Aug 12, 2015
sparrc
added a commit
that referenced
this pull request
Aug 12, 2015
Merge of PR #107, Allow Telegraf to output data to multiple locations beyond InfluxDB, such as Riemann or Kafka
|
Closing this PR because it got covered by PR #109, apologies that most of your commits got covered up, the rebasing got a little bit crazy ;-) Thanks so much @jipperinbham! This is huge! |
|
@sparrc thanks for all the help getting this in! Hope to get started on a new output soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_NOTE_
_BREAKING CHANGE_
Once this is merged, all existing config.toml files will be invalid and need to be updated. All examples in the project have been updated with the new format.
Attempt to move the InfluxDB client into an
outputspkg to allow for different outputs in the future.@sparrc there's still some merge conflicts but I've done my best to get everything as close to master as possible where I can. Everything has been
go veted andgolinted.