Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Back button missing sometimes - works with "ionic": "v1.0.0-rc.3" #4132

Closed
Robinyo opened this issue Jul 22, 2015 · 12 comments
Closed

bug: Back button missing sometimes - works with "ionic": "v1.0.0-rc.3" #4132

Robinyo opened this issue Jul 22, 2015 · 12 comments

Comments

@Robinyo
Copy link

Robinyo commented Jul 22, 2015

Type: bug

Platform: all

See -> http://forum.ionicframework.com/t/back-button-missing-sometimes/28235/9

@yewnork - Its a BUG 馃槮
@cormacodonnell
@DonEllingsworth
@harmonics

See this fork of your Plunker: http://plnkr.co/edit/JVvifeOX5VSDGoa8lrTJ?p=preview

I updated the Plunker to use 1-0-1 (http://forum.ionicframework.com/t/1-0-1-vanadium-vaquita-released/27420) which didn't work so I checked my bower.json and noticed that I am still using:

"ionic": "v1.0.0-rc.3"

which works, index.html:

<link rel="stylesheet" href="http://code.ionicframework.com/1.0.0-rc.3/css/ionic.css" />
<link rel="stylesheet" href="style.css" />
<script src="http://code.ionicframework.com/1.0.0-rc.3/js/ionic.bundle.js"></script>

Note: I also updated from href to ui-sref in several files + fixed 'menu.html' as well :)

@Robinyo Robinyo changed the title Back button missing sometimes - works with "ionic": "v1.0.0-rc.3" bug: Back button missing sometimes - works with "ionic": "v1.0.0-rc.3" Jul 22, 2015
@Robinyo
Copy link
Author

Robinyo commented Jul 23, 2015

Just tried:

"ionic": "v1.0.0"

Which works, but:

"ionic": "v1.0.1"

doesn't :(

@kamleshkoringa
Copy link

I have same issue with version 1.0.1

Here is code pen demo. http://codepen.io/anon/pen/wamRVX4

Sequence to reproduce

  1. Select Check in from side menu.
  2. Click on Attendees on main page new page will display back button
  3. Click back which will return to Check in page
  4. Now select check in from side menu (Even if same page is open)
  5. Click on Attendees link new page will not display Back button

@Robinyo
Copy link
Author

Robinyo commented Jul 23, 2015

Plunker Ionic 1.0.1: http://plnkr.co/edit/wzh9enXseYHfhakdxXhm?p=preview

@Robinyo
Copy link
Author

Robinyo commented Jul 23, 2015

Plunker "Playlists - Ionic v1.0.0":

http://plnkr.co/edit/pGwucVrTBDxSvw6z092h?p=preview

@mhartington
Copy link
Member

@Robinyo so whats the difference between these two plunkrs?

This one, http://plnkr.co/edit/pGwucVrTBDxSvw6z092h?p=preview , works as expected.

@mhartington mhartington added the needs: reply the issue needs a response from the user label Jul 27, 2015
@Robinyo
Copy link
Author

Robinyo commented Jul 27, 2015

That's correct, Plunker "Playlists - Ionic v1.0.0" - http://plnkr.co/edit/pGwucVrTBDxSvw6z092h?p=preview displays a '<' back button if you:

  1. Tap 'Reggae'
  2. Tap '<'
  3. Tap 'nav-icon'
  4. Tap 'Playlists' shows Playlist with a '<' back button

If you follow the same steps with the Ionic v1.0.1 Plunker - http://plnkr.co/edit/wzh9enXseYHfhakdxXhm?p=preview it displays a 'nav-icon' NOT a '<' back button.

So, the 'bug' was introduced in Ionic version 1.0.1.

@Ionitron Ionitron removed the needs: reply the issue needs a response from the user label Jul 27, 2015
@mhartington
Copy link
Member

There's a small list of changes in 1.0.1, and only two that may be the culprit.

https://github.com/driftyco/ionic/blob/master/CHANGELOG.md#101-vanadium-vaquita-2015-06-30

@mhartington
Copy link
Member

Okay, so cef6708 is the culprit, looking into a fix

@abhayastudios
Copy link

@perrygovier I am still seeing this behavior in ionic v1.1.0 where eventually I will see this in the console:

TypeError: Cannot read property 'expire' of null
    at ionic.bundle.js:47159
    at Scope.$broadcast (ionic.bundle.js:24992)
    at y.transition.M.then.y.transition.y.transition (angular-ui-router.min.js:7)
    at processQueue (ionic.bundle.js:23394)
    at ionic.bundle.js:23410
    at Scope.$eval (ionic.bundle.js:24673)
    at Scope.$digest (ionic.bundle.js:24484)
    at Scope.$apply (ionic.bundle.js:24778)
    at ionic.bundle.js:26545
    at completeOutstandingRequest (ionic.bundle.js:14221)

When using the menu-toggle attribute it is working fine.

@ajp8164
Copy link

ajp8164 commented Jan 27, 2016

This issue remains unresolved. Using Ionic 1.7.12. The error occurs in nextViewOption() in the deregisterStateChangeListener. When a $stateChangeSuccess event occurs it's handler is called. nextViewOptions is null when the event occurs which triggers the error at nextViewOptions.expire when calling $timeout().

nextViewOptions: function(opts) {
      deregisterStateChangeListener && deregisterStateChangeListener();
      if (arguments.length) {
        $timeout.cancel(nextViewExpireTimer);
        if (opts === null) {
          nextViewOptions = opts;
        } else {
          nextViewOptions = nextViewOptions || {};
          extend(nextViewOptions, opts);
          if (nextViewOptions.expire) {
              deregisterStateChangeListener = $rootScope.$on('$stateChangeSuccess', function() {
                nextViewExpireTimer = $timeout(function() {
                  nextViewOptions = null;
                  }, **nextViewOptions.expire**);
              });
          }
        }
      }
      return nextViewOptions;
    },

@rafatrace
Copy link

This occurs to me to, on Ionic 1.7.14.

@mrah
Copy link

mrah commented Feb 21, 2016

Me too.. v 1.7.14

0 226745 error Error: null is not an object (evaluating 'nextViewOptions.expire') http://192.168.1.101:8101/lib/ionic/js/ionic.bundle.js:51661:37 $broadcast@http://192.168.1.101:8101/lib/ionic/js/ionic.bundle.js:29477:33 http://192.168.1.101:8101/lib/ionic/js/ionic.bundle.js:49321:32 processQueue@http://192.168.1.101:8101/lib/ionic/js/ionic.bundle.js:27879:30 http://192.168.1.101:8101/lib/ionic/js/ionic.bundle.js:27895:39 $eval@http://192.168.1.101:8101/lib/ionic/js/ionic.bundle.js:29158:28 $digest@http://192.168.1.101:8101/lib/ionic/js/ionic.bundle.js:28969:36 $apply@http://192.168.1.101:8101/lib/ionic/js/ionic.bundle.js:29263:31 http://192.168.1.101:8101/lib/ionic/js/ionic.bundle.js:31030:42 completeOutstandingRequest@http://192.168.1.101:8101/lib/ionic/js/ionic.bundle.js:18706:15 http://192.168.1.101:8101/lib/ionic/js/ionic.bundle.js:18978:33

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants