perf($q): small $q performance optimization

Only generate a new promise when `then` receives some non-undefined parameter Closes #12535
angular · Aug 11, 2015 · 6838c97 · 6838c97 · matsko · Aug 14, 2015
1 parent f827a8e
commit 6838c97
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/lib/promises-aplus/promises-aplus-test-adapter.js b/lib/promises-aplus/promises-aplus-test-adapter.js
@@ -4,6 +4,8 @@
 var isFunction = function isFunction(value){return typeof value == 'function';};
 var isPromiseLike = function isPromiseLike(obj) {return obj && isFunction(obj.then);};
 var isObject = function isObject(value){return value != null && typeof value === 'object';};
+var isUndefined = function isUndefined(value) {return typeof value === 'undefined';};
+
 var minErr = function minErr (module, constructor) {
   return function (){
     var ErrorConstructor = constructor || Error;

diff --git a/src/ng/q.js b/src/ng/q.js
@@ -274,6 +274,9 @@ function qFactory(nextTick, exceptionHandler) {
 
   extend(Promise.prototype, {
     then: function(onFulfilled, onRejected, progressBack) {
+      if (isUndefined(onFulfilled) && isUndefined(onRejected) && isUndefined(progressBack)) {
+        return this;
+      }
       var result = new Deferred();
 
       this.$$state.pending = this.$$state.pending || [];