This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngSanitize): escape the wide char quote marks in a regex in linky.js #11609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
Signed the CLA. |
|
CLAs look good, thanks! |
luanshixia
changed the title
petebacondarwin
added
branch: 1.3.x
component: ngSanitize
type: bug
and removed
cla: yes
labels
netman92
pushed a commit
to netman92/angular.js
that referenced
this pull request
Aug 8, 2015
Escape the wide char quote marks in a regex in linky.js Closes angular#11609
ggershoni
pushed a commit
to ggershoni/angular.js
that referenced
this pull request
Sep 29, 2015
Escape the wide char quote marks in a regex in linky.js Closes angular#11609
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11598
It is all about the wide quote mark chars introduced in 1.3.x. I have escaped these chars.
Actually the escaped chars are what is in the compressed sanitize.min.js. If not escaped, there is a chance to get messed up on some machines, causing the script not working.