Skip to content
This repository has been archived by the owner on Apr 13, 2022. It is now read-only.

fix(ngAnimate): always apply a preparation reflow for CSS-based animations #12554

Closed
wants to merge 1 commit into from

Conversation

matsko
Copy link
Contributor

@matsko matsko commented Aug 12, 2015

It's unpredictable sometimes to ensure that a browser triggers a reflow
for an animation. Prior to this patch, reflows would be applied
carefully in between parent/child DOM structure, but that doesn't seem
to be enough for animations that contain complex CSS styling rules.

Closes #12553
Closes #12554
Closes #12267

…tions

It's unpredictable sometimes to ensure that a browser triggers a reflow
for an animation. Prior to this patch, reflows would be applied
carefully in between parent/child DOM structure, but that doesn't seem
to be enough for animations that contain complex CSS styling rules.

Closes angular#12553
Closes angular#12554
Closes angular#12267
@matsko matsko force-pushed the fix_ng_show_hide branch 2 times, most recently from bad9106 to f6e7a9b Compare August 12, 2015 01:36
@lgalfaso
Copy link
Contributor

I am slightly worried that this can cause some performance issues, but the problems are just too big not to merge this

@lgalfaso
Copy link
Contributor

landed as d33cedd

@lgalfaso lgalfaso closed this Aug 12, 2015
matsko added a commit that referenced this pull request Aug 12, 2015
…tions

It's unpredictable sometimes to ensure that a browser triggers a reflow
for an animation. Prior to this patch, reflows would be applied
carefully in between parent/child DOM structure, but that doesn't seem
to be enough for animations that contain complex CSS styling rules.

Closes #12553
Closes #12554
Closes #12267
Closes #12554
lee-tunnicliffe pushed a commit to lee-tunnicliffe/angular.js that referenced this pull request Aug 13, 2015
…tions

It's unpredictable sometimes to ensure that a browser triggers a reflow
for an animation. Prior to this patch, reflows would be applied
carefully in between parent/child DOM structure, but that doesn't seem
to be enough for animations that contain complex CSS styling rules.

Closes angular#12553
Closes angular#12554
Closes angular#12267
Closes angular#12554
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants