Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

ngShow is broken in master #12553

Closed
matsko opened this issue Aug 12, 2015 · 0 comments
Closed

ngShow is broken in master #12553

matsko opened this issue Aug 12, 2015 · 0 comments

Comments

@matsko
Copy link
Contributor

matsko commented Aug 12, 2015

No version has been released just yet, but ngShow and ngHide do not get caught with the new class based reflow fix.

Broken:
http://plnkr.co/edit/qWpK7YWCwMjSKb5eTtXk?p=preview

Fixed:
http://plnkr.co/edit/zqhheQydJH7uta6QYgHG?p=preview
matsko added a commit to matsko/angular.js that referenced this issue Aug 12, 2015
@matsko
fix(ngAnimate): always apply a preparation reflow for CSS-based anima…
d8d121a 
…tions

It's unpredictable sometimes to ensure that a browser triggers a reflow
for an animation. Prior to this patch, reflows would be applied
carefully in between parent/child DOM structure, but that doesn't seem
to be enough for animations that contain complex CSS styling rules.

Closes angular#12553
@matsko matsko mentioned this issue Aug 12, 2015
Closed
matsko added a commit to matsko/angular.js that referenced this issue Aug 12, 2015
@matsko
fix(ngAnimate): always apply a preparation reflow for CSS-based anima…
bad9106 
…tions

It's unpredictable sometimes to ensure that a browser triggers a reflow
for an animation. Prior to this patch, reflows would be applied
carefully in between parent/child DOM structure, but that doesn't seem
to be enough for animations that contain complex CSS styling rules.

Closes angular#12553
Closes angular#12267
matsko added a commit to matsko/angular.js that referenced this issue Aug 12, 2015
@matsko
fix(ngAnimate): always apply a preparation reflow for CSS-based anima…
f6e7a9b 
…tions

It's unpredictable sometimes to ensure that a browser triggers a reflow
for an animation. Prior to this patch, reflows would be applied
carefully in between parent/child DOM structure, but that doesn't seem
to be enough for animations that contain complex CSS styling rules.

Closes angular#12553
Closes angular#12554
Closes angular#12267
@matsko matsko closed this as completed in d33cedd Aug 12, 2015
lee-tunnicliffe pushed a commit to lee-tunnicliffe/angular.js that referenced this issue Aug 13, 2015
@matsko @lee-tunnicliffe
fix(ngAnimate): always apply a preparation reflow for CSS-based anima…
28ad319 
…tions

It's unpredictable sometimes to ensure that a browser triggers a reflow
for an animation. Prior to this patch, reflows would be applied
carefully in between parent/child DOM structure, but that doesn't seem
to be enough for animations that contain complex CSS styling rules.

Closes angular#12553
Closes angular#12554
Closes angular#12267
Closes angular#12554
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matsko