This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Negative currency amount is displayed as $-xxx,xxx.xx for en-us culture #10158

Closed

clement911 opened this issue Nov 21, 2014 · 6 comments

Assignees

Labels

component: filters frequency: low needs: investigation severity: broken expected use type: bug

Milestone

clement911 commented Nov 21, 2014

Shouldn't a negative currency amount be displayed -$xxx,xxx.xx for en-us ?

With that commit it will show as $-xxx,xxx.xx which is kind of weird...

Member

petebacondarwin commented Nov 21, 2014

I believe that this is because the en-us locale info in CLDR does not provide a specific negative pattern and so we "guess" at it on this line: https://github.com/angular/angular.js/blob/master/i18n/src/parser.js#L59

petebacondarwin added type: bug severity: broken expected use needs: investigation frequency: low labels

petebacondarwin added this to the Backlog milestone

IgorMinar modified the milestones: ngfix, Backlog, ng-fixit #1

Contributor

shwei commented Nov 22, 2014

@clement911 Using currency filter, the current display of negative US currency is wrapped around by parenthesis. e.g. ($1234.56) . Sample: http://plnkr.co/edit/w16eMG8LzJ1pe4iuPaum?p=preview

Don't know how you did it so I can reproduce it. Can you please provide a Plnkr? Thanks!

Member

petebacondarwin commented Nov 23, 2014

@shwei - you need to load the en-US locale. See http://plnkr.co/edit/Gz9GcM1CarYuD4YRV5VB?p=preview

pkozlowski-opensource added the component: filters label

Author

clement911 commented Nov 23, 2014

I'm pretty sure this line is where the regression is:
https://github.com/angular/angular.js/blob/master/src/ngLocale/angular-locale_en-us.js#L105

By the way, this issue affects other cultures too, for example en-au.

Author

clement911 commented Nov 27, 2014

@petebacondarwin when "guessing" the negative pattern would it be more appropriate to use
p.negPre = '-' + p.posPre;
instead of
p.negPre = p.posPre + '-';

Contributor

shwei commented Nov 30, 2014

Thanks for the clarification, @clement911 and @petebacondarwin. I think in en-us '-' + p.posPre makes more sense.

Based on CLDR's documentation, displaying negative currency with a parenthesis around the number is a currency-accounting type. http://cldr.unicode.org/translation/number-patterns They changed the default display of a negative currency from a number in a parenthesis to prefixing it with a minus sign. A number in a parenthesis for negative currency is considered an accounting form based on this ticket: http://unicode.org/cldr/trac/ticket/5674

So for en-us, should we make negative currency to be displayed like -$123.45?

petebacondarwin assigned lgalfaso

lgalfaso removed their assignment

petebacondarwin added a commit to petebacondarwin/angular.js that referenced this issue


          fix(i18n): by default put negative sign before currency symbol

bbd4c4e

It seems that the case where the negative sign goes between the currency
symbol and the numeric value is actually the special case and that locales
that require this have it built in. So we should default to having the
negative sign before the symbol.

See http://cldr.unicode.org/translation/number-patterns

Closes angular#10158

petebacondarwin added a commit to petebacondarwin/angular.js that referenced this issue


          fix(i18n): by default put negative sign before currency symbol

97e9a63

It seems that the case where the negative sign goes between the currency
symbol and the numeric value is actually the special case and that locales
that require this have it built in. So we should default to having the
negative sign before the symbol.

See http://cldr.unicode.org/translation/number-patterns and
http://unicode.org/cldr/trac/ticket/5674

Closes angular#10158

petebacondarwin self-assigned this

petebacondarwin mentioned this issue

I18n changes #12362

Merged

petebacondarwin added a commit to petebacondarwin/angular.js that referenced this issue


          fix(i18n): by default put negative sign before currency symbol

8fa8dde

It seems that the case where the negative sign goes between the currency
symbol and the numeric value is actually the special case and that locales
that require this have it built in. So we should default to having the
negative sign before the symbol.

See http://cldr.unicode.org/translation/number-patterns and
http://unicode.org/cldr/trac/ticket/5674

Closes angular#10158

petebacondarwin added a commit to petebacondarwin/angular.js that referenced this issue


          fix(i18n): by default put negative sign before currency symbol

96f2e3b

It seems that the case where the negative sign goes between the currency
symbol and the numeric value is actually the special case and that locales
that require this have it built in. So we should default to having the
negative sign before the symbol.

See http://cldr.unicode.org/translation/number-patterns and
http://unicode.org/cldr/trac/ticket/5674

Closes angular#10158

petebacondarwin closed this as completed in #12362

petebacondarwin added a commit that referenced this issue


          fix(ng/$locale): by default put negative sign before currency symbol

It seems that the case where the negative sign goes between the currency
symbol and the numeric value is actually the special case and that locales
that require this have it built in. So we should default to having the
negative sign before the symbol.

See http://cldr.unicode.org/translation/number-patterns and
http://unicode.org/cldr/trac/ticket/5674

Closes #10158

netman92 pushed a commit to netman92/angular.js that referenced this issue


          fix(i18n): by default put negative sign before currency symbol

2b3e9db

It seems that the case where the negative sign goes between the currency
symbol and the numeric value is actually the special case and that locales
that require this have it built in. So we should default to having the
negative sign before the symbol.

See http://cldr.unicode.org/translation/number-patterns and
http://unicode.org/cldr/trac/ticket/5674

Closes angular#10158

netman92 pushed a commit to netman92/angular.js that referenced this issue


          fix(ng/$locale): by default put negative sign before currency symbol

7526fe7

It seems that the case where the negative sign goes between the currency
symbol and the numeric value is actually the special case and that locales
that require this have it built in. So we should default to having the
negative sign before the symbol.

See http://cldr.unicode.org/translation/number-patterns and
http://unicode.org/cldr/trac/ticket/5674

Closes angular#10158

ggershoni pushed a commit to ggershoni/angular.js that referenced this issue


          fix(i18n): by default put negative sign before currency symbol

76857fc

It seems that the case where the negative sign goes between the currency
symbol and the numeric value is actually the special case and that locales
that require this have it built in. So we should default to having the
negative sign before the symbol.

See http://cldr.unicode.org/translation/number-patterns and
http://unicode.org/cldr/trac/ticket/5674

Closes angular#10158

ggershoni pushed a commit to ggershoni/angular.js that referenced this issue


          fix(ng/$locale): by default put negative sign before currency symbol

8a4d090

It seems that the case where the negative sign goes between the currency
symbol and the numeric value is actually the special case and that locales
that require this have it built in. So we should default to having the
negative sign before the symbol.

See http://cldr.unicode.org/translation/number-patterns and
http://unicode.org/cldr/trac/ticket/5674

Closes angular#10158

vladlep mentioned this issue

currency filter on negative value not in parentheses - AngularJS 1.3 to 1.4 regression #12870

Open

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.