This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix($rootScope): Internal state consistency #12174
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgalfaso
force-pushed
the
no-clean-state
branch
2 times, most recently
from
a1d319b
to
301a737
Compare
|
Although this is logically correct, I find it unnecessarily complicated to follow. Instead, we should simply wrap the try {
beginPhase('$apply');
try {
return this.$eval(expr);
} finally {
clearPhase();
}
} catch(e) {
$exceptionHandler(e);
} finally {
try {
$rootScope.$digest();
} catch(e) {
$exceptionHandler(e);
throw e;
}
} |
During a recursive $apply, clear the state only if the state was set in that call.
|
@petebacondarwin I wanted to avoid the second |
lgalfaso
added a commit
that referenced
this pull request
Jul 25, 2015
We cannot re-enter a `$apply` block while already in a `$apply` or `$digest` phase. Before this change such an invalid call to `$apply` was incorrectly clearing the phase, which meant that a second invalid `$apply` call was being allowed. Closes #12174
netman92
pushed a commit
to netman92/angular.js
that referenced
this pull request
Aug 8, 2015
We cannot re-enter a `$apply` block while already in a `$apply` or `$digest` phase. Before this change such an invalid call to `$apply` was incorrectly clearing the phase, which meant that a second invalid `$apply` call was being allowed. Closes angular#12174
ggershoni
pushed a commit
to ggershoni/angular.js
that referenced
this pull request
Sep 29, 2015
We cannot re-enter a `$apply` block while already in a `$apply` or `$digest` phase. Before this change such an invalid call to `$apply` was incorrectly clearing the phase, which meant that a second invalid `$apply` call was being allowed. Closes angular#12174
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During a recursive $apply, clear the state only if the state was set in that call.