Navigation Menu

Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

ng-form cannot show message & remove item from arry #12249

Closed
kimx opened this issue Jul 1, 2015 · 5 comments
Closed

ng-form cannot show message & remove item from arry #12249

kimx opened this issue Jul 1, 2015 · 5 comments
Labels
component: forms component: ngMessages resolution: duplicate
Milestone
Purgatory

Comments

@kimx
Copy link

kimx commented Jul 1, 2015

Hello
when I upgrade version from 1.3.16 to 1.4.1 ,I occur some errors.

  • ng-message cannot show， But if I downgrade to angular-messages .1.3.16 it can be work.
  • When some input has validation in ng-form ,It cannot be remove from an array.I found the problem cause by when inject module of ng-animate e.g
    angular.module("App", ["ngMessages", "ngAnimate"])
    see Plunker

please help me ,thanks a lot
@kimx kimx changed the title ng-form in ng-repeat cannot show message & remove item from arry ng-form in ng-form cannot show message & remove item from arry Jul 1, 2015
@kimx kimx changed the title ng-form in ng-form cannot show message & remove item from arry ng-form cannot show message & remove item from arry Jul 1, 2015
@Narretz
Copy link
Contributor

Narretz commented Jul 2, 2015

Can you please provide a plnkr or similar for these issues, especially the first? The second one sounds like a known ngAnimate bug.

@Narretz Narretz added this to the Purgatory milestone Jul 2, 2015
@kimx
Copy link
Author

kimx commented Jul 3, 2015

For first Issue ng-message cannot show ,this plunker can show ,for this sample just clear any value of input,that will show validation message,but if I change 1.3.16 to 1.4.1 ,the message cannot show.

@gkalpak
Copy link
Member

gkalpak commented Jul 3, 2015

Regarding the 1st issue, there have been some changes in ngMessages on 1.4.x, so the ng-messages expression is not interpolated.
To make it work on both versions, change rowForm['item.name{{$index}}'].$error to rowForm['item.name'+$index].$error (updated plnkr).

@kimx
Copy link
Author

kimx commented Jul 3, 2015

@gkalpak thanks 1st issue can work, @Narretz about second issue will be fix in next version? thanks a lot .

@sreeramu sreeramu mentioned this issue Jul 5, 2015
Closed
@Narretz
Copy link
Contributor

Narretz commented Aug 5, 2015

@kimx Sorry, we don't have a fix for that yet. It's been tracked in issue #12161, so I'll close this one.

@Narretz Narretz closed this as completed Aug 5, 2015
matsko pushed a commit to matsko/angular.js that referenced this issue Aug 12, 2015
@sreeramu @matsko
fix($animate): leave animation callback should not overridden by foll…
f3fa3e7 
…ow-up animation

Closes angular#12271
Closes angular#12249
Closes angular#12161
@matsko matsko mentioned this issue Aug 12, 2015
Closed
matsko pushed a commit that referenced this issue Aug 12, 2015
@sreeramu @matsko
fix($animate): leave animation callback should not overridden by foll…
92e41ac 
…ow-up animation

Closes #12271
Closes #12249
Closes #12161
lee-tunnicliffe pushed a commit to lee-tunnicliffe/angular.js that referenced this issue Aug 13, 2015
@sreeramu @lee-tunnicliffe
fix($animate): leave animation callback should not overridden by foll…
887948a 
…ow-up animation

Closes angular#12271
Closes angular#12249
Closes angular#12161
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: forms component: ngMessages resolution: duplicate
Projects
None yet
Milestone
Purgatory
Development

Successfully merging a pull request may close this issue.

PR refactor for #12271 matsko/angular.js
3 participants
@Narretz @kimx @gkalpak