Uploaded image for project: 'Mesos'
  1. Mesos
  2. MESOS-2519

Log IP addresses from HTTP requests

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 0.23.0
    • None
    • Twitter Q2 Sprint 2, Twitter Mesos Q2 Sprint 5
    • 3

    Description

      Querying /master/state.json is an expensive operation when a cluster is large, and it's possible to DOS the master via frequent and repeated queries (which is a separate problem). Querying the endpoint results in a log entry being written, but the entry lacks useful information, such as an IP address, response code and response size. These details are useful for tracking down who/what is querying the endpoint. Consider adding these details to the log entry, or even writing a separate access log. Also consider writing log entries for all HTTP requests (/metrics/snapshot produces no log entries).

      sample log entry
      I0319 18:06:18.824846 10521 http.cpp:478] HTTP request for '/master/state.json'
      

      Attachments

        Issue Links

          Activity

            People

              bmahler Benjamin Mahler
              drobinson Daniel Robinson
              Vinod Kone Vinod Kone
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: