Custom primary key field name + scope with include causes primary key field to be duplicated on every query #4127

ghost · 2015-07-16T09:05:32Z

I have a one-to-many relationship between rooms and meetings. The meetings have a custom field name for the primary key column. The code is here: https://gist.github.com/sheepcount/b7505eec4ef82e34ed95.

When querying multiple times using my scope nested, the primary key column gets duplicated every time. At some point, query length will exceed the maximum field number of the database, and the app has to be restarted.

The problem seems to be in model.js: validateIncludedElement() checks for if (include.attributes.indexOf(attr) === -1), however, with custom field names, include.attributes will contain arrays for the fields and thus the check won't detect the primary key already present and re-add it every time a query is performed.

First query:

SELECT "Room"."id", "Room"."number", "Room"."createdAt", "Room"."updatedAt", 
 "Meetings"."customID" AS "Meetings.id", 
 "Meetings"."description" AS "Meetings.description", 
 "Meetings"."createdAt" AS "Meetings.createdAt", 
 "Meetings"."updatedAt" AS "Meetings.updatedAt", 
 "Meetings"."RoomId" AS "Meetings.RoomId" 
 FROM "Rooms" AS "Room" LEFT OUTER JOIN "Meetings" AS "Meetings" 
 ON "Room"."id" = "Meetings"."RoomId" WHERE "Room"."number" = '101';

Second query:

SELECT "Room"."id", "Room"."number", "Room"."createdAt", "Room"."updatedAt", 
 "Meetings"."customID" AS "Meetings.id", 
 "Meetings"."customID" AS "Meetings.id", 
 "Meetings"."description" AS "Meetings.description", 
 "Meetings"."createdAt" AS "Meetings.createdAt", 
 "Meetings"."updatedAt" AS "Meetings.updatedAt", 
 "Meetings"."RoomId" AS "Meetings.RoomId" 
 FROM "Rooms" AS "Room" LEFT OUTER JOIN "Meetings" AS "Meetings" 
 ON "Room"."id" = "Meetings"."RoomId" WHERE "Room"."number" = '101';

Third query:

SELECT "Room"."id", "Room"."number", "Room"."createdAt", "Room"."updatedAt", 
 "Meetings"."customID" AS "Meetings.id", 
 "Meetings"."customID" AS "Meetings.id", 
 "Meetings"."customID" AS "Meetings.id", 
 "Meetings"."description" AS "Meetings.description", 
 "Meetings"."createdAt" AS "Meetings.createdAt", 
 "Meetings"."updatedAt" AS "Meetings.updatedAt", 
 "Meetings"."RoomId" AS "Meetings.RoomId" 
 FROM "Rooms" AS "Room" LEFT OUTER JOIN "Meetings" AS "Meetings" 
 ON "Room"."id" = "Meetings"."RoomId" WHERE "Room"."number" = '101';

The text was updated successfully, but these errors were encountered:

janmeier added the type: bug label Jul 16, 2015

janmeier closed this as completed in 2d3360c Jul 25, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Custom primary key field name + scope with include causes primary key field to be duplicated on every query #4127

Custom primary key field name + scope with include causes primary key field to be duplicated on every query #4127

ghost commented Jul 16, 2015

Custom primary key field name + scope with include causes primary key field to be duplicated on every query #4127

Custom primary key field name + scope with include causes primary key field to be duplicated on every query #4127

Comments

ghost commented Jul 16, 2015