Add test case for scope with includes #3991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The problem was that we didn't call conformOptions (converting the include to the form expected later on) when a scope is a function |
| return { | ||
| include: [{ | ||
| model: sequelize.models.Company, | ||
| include: [sequelize.models.Project.scope('active')] |
There was a problem hiding this comment.
Changing this to .project - the models are stored under their name :)
janmeier
added a commit
that referenced
this pull request
Jul 25, 2015
Add test case for scope with includes
janmeier
added a commit
that referenced
this pull request
Jul 25, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seem to be some issues preventing use of includes inside scope definitions. These tests should reproduce the problems.
WIP, I'll be abusing the PR system for travis-ci checking.