Send full response for unsupported websocket versions #3999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AUTOMATED MESSAGE for ADMINS: |
|
@netkins accept |
| @@ -0,0 +1,51 @@ | |||
| /* | |||
| * Copyright 2013 The Netty Project | |||
|
@jroper thanks! Could you please address my two comments and adjust the commit message to match our commit message template: https://github.com/netty/netty/wiki/Writing-a-commit-message After this I will cherry-pick. Thanks! |
Motivation: WebSocketServerHandshakerFactory.sendUnsupportedVersionResponse does not send a LastHttpContent, nor does it flush, and it doesn't send a content length. Modifications: Changed sendUnsupportedVersionResponse to send FullHttpResponse, to writeAndFlush, and to set a content length of 0. Also added a test for this method. Result: Upstream handlers will be able to determine the end of the response, the response will actually get written to the client, and the client will be able to determine the end of the response.
|
@normanmaurer done. By the way, I don't have any need for this change to be back ported, I found the problems when I copied the code to create the response (I couldn't use the method because I didn't want to write it immediately to the channel), so I thought I'd submit this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the WebSocketServerHandshakerFactory sent a response if the websocket verison was not expected, it had three problems, first it didn't send a LastHttpContent, leaving any upstream handlers that were tracking responses thinking the response wasn't finished, second it didn't flush, so the response was never actually sent, and third, if it did somehow manage to flush, it didn't send a content length, leaving the client waiting to receive a close delimited body.