Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly register for EPOLLRDHUP when construct EpollSocketChannel f… #4013

Merged
merged 1 commit into from Jul 21, 2015

Conversation

normanmaurer
Copy link
Member

…rom FileDescriptor

Motivation:

We missed to register for EPOLLRDHUP events when construct the EpollSocketChannel from an existing FileDescriptor. This could cause to miss connection-resets.

Modifications:

Add Native.EPOLLRDHUP to the events we are interested in.

Result:

Connection-resets are detected correctly.

…rom FileDescriptor

Motivation:

We missed to register for EPOLLRDHUP events when construct the EpollSocketChannel from an existing FileDescriptor. This could cause to miss connection-resets.

Modifications:

Add Native.EPOLLRDHUP to the events we are interested in.

Result:

Connection-resets are detected correctly.
@normanmaurer normanmaurer self-assigned this Jul 21, 2015
@normanmaurer normanmaurer added this to the 4.0.30.Final milestone Jul 21, 2015
@normanmaurer normanmaurer merged commit 5c7022d into 4.0 Jul 21, 2015
@normanmaurer
Copy link
Member Author

Cherry-picked into 4.0 (5c7022d), 4.1 (1a5dac1) and master (22cea8a)

@normanmaurer normanmaurer deleted the epoll_fix branch July 21, 2015 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant