Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#3988] Correctly count acquired channels in FixedChannelPool #4016

Closed
wants to merge 1 commit into from
Closed

[#3988] Correctly count acquired channels in FixedChannelPool #4016

wants to merge 1 commit into from

Conversation

normanmaurer
Copy link
Member

Motivation:

We missed to correctly count acquired channels in FixedChannelPool which could produce an assert error.

Modifications:

Only try to decrement acquired count if the channel was really acuired.

Result:

No more assert error possible.

@normanmaurer
[#3988] Correctly count acquired channels in FixedChannelPool
3eee4f3 
Motivation:

We missed to correctly count acquired channels in FixedChannelPool which could produce an assert error.

Modifications:

Only try to decrement acquired count if the channel was really acuired.

Result:

No more assert error possible.
@normanmaurer normanmaurer self-assigned this Jul 21, 2015
@normanmaurer normanmaurer added this to the 4.0.30.Final milestone Jul 21, 2015
@normanmaurer normanmaurer mentioned this pull request Jul 21, 2015
Closed
@normanmaurer
Copy link
Member Author

Cherry-picked into 4.0 (467a07a), 4.1 (bd42987) and master (1a34427)

@normanmaurer normanmaurer deleted the fix_pool_acquire branch July 21, 2015 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@normanmaurer normanmaurer

Labels
defect
Projects
None yet
Milestone
4.0.30.Final
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@normanmaurer