Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3967] Guard against NPE in PendingWriteQueue #3991

Closed
wants to merge 1 commit into from

Conversation

normanmaurer
Copy link
Member

Motivation:

If the Channel is already closed when the PendingWriteQueue is created it will generate a NPE when add or remove is called later.

Modifications:

Add null checks to guard against NPE.

Result:

No more NPE possible.

Motivation:

If the Channel is already closed when the PendingWriteQueue is created it will generate a NPE when add or remove is called later.

Modifications:

Add null checks to guard against NPE.

Result:

No more NPE possible.
@normanmaurer normanmaurer self-assigned this Jul 15, 2015
@normanmaurer normanmaurer added this to the 4.0.30.Final milestone Jul 15, 2015
@normanmaurer
Copy link
Member Author

@trustin please check

@normanmaurer
Copy link
Member Author

Cherry-picked into 4.0 (ae32fd4) , 4.1 (f1c5f0e) and master (1be2173)

@normanmaurer normanmaurer deleted the pending_write_queue_npe branch July 17, 2015 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant