Ensure OpenSslSession informations can be retrieved even after shutdown #3934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: If a user tries to access various informations on the OpenSslSession after the SSLEngine was closed it will not work if these were not accessed before as we lazy init most of them. Modifications: Directly populate the whole OpenSslSession once the handshake is complete and before the user is notified about it. Result: OpenSslSession informations are avaible until it is GC'ed.
|
@trustin please check |
| import java.security.SignatureException; | ||
| import java.util.Date; | ||
|
|
||
| final class OpenSslJavaxX509Certificate extends X509Certificate { |
There was a problem hiding this comment.
Maybe it's enough to name this class as OpenSslX509Certificate?
There was a problem hiding this comment.
@trustin we already have OpenSslX509Certificate for java.security.X509Certificate impl :/
|
LGTM :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
If a user tries to access various informations on the OpenSslSession after the SSLEngine was closed it will not work if these were not accessed before as we lazy init most of them.
Modifications:
Directly populate the whole OpenSslSession once the handshake is complete and before the user is notified about it.
Result:
OpenSslSession informations are avaible until it is GC'ed.