ServerBootstrap.handler(...) will add handler before Channel is regis… #3933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@trustin please check |
| @@ -181,7 +177,11 @@ void init(Channel channel) throws Exception { | |||
| p.addLast(new ChannelInitializer<Channel>() { | |||
| @Override | |||
| public void initChannel(Channel ch) throws Exception { | |||
| ch.pipeline().addLast(new ServerBootstrapAcceptor( | |||
| ChannelPipeline pipeline = ch.pipeline(); | |||
| if (handler() != null) { | |||
There was a problem hiding this comment.
handler() could be extracted into a local variable.
|
LGTM. Please feel free to cherry-pick after addressing one nit. |
…tered. Motivation: If you set a ChannelHandler via ServerBootstrap.handler(...) it is added to the ChannelPipeline before the Channel is registered. This will lead to and IllegalStateException if a user tries to access the EventLoop in the ChannelHandler.handlerAdded(...) method. Modifications: Delay the adding of the ChannelHandler until the Channel was registered. Result: No more IllegalStateException.
normanmaurer
force-pushed
the
serverbootstrap_handler_fix
branch
from
2fa1ea1
to
4e049be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tered.
Motivation:
If you set a ChannelHandler via ServerBootstrap.handler(...) it is added to the ChannelPipeline before the Channel is registered. This will lead to and IllegalStateException if a user tries to access the EventLoop in the ChannelHandler.handlerAdded(...) method.
Modifications:
Delay the adding of the ChannelHandler until the Channel was registered.
Result:
No more IllegalStateException.