Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix IRCFirehoseFactory json name/nick mismatch #1331

Merged
merged 1 commit into from May 1, 2015
Merged

fix IRCFirehoseFactory json name/nick mismatch #1331

merged 1 commit into from May 1, 2015

Conversation

drcrallen
Copy link
Contributor

  • Now it is nick as per wikipedia example

@drcrallen
fix IRCFirehoseFactory json name/nick mismatch
27e25fe 
* Now it is nick as per wikipedia example
@drcrallen
Copy link
Contributor Author

Closing to test real quick

@drcrallen drcrallen closed this May 1, 2015
@drcrallen
Copy link
Contributor Author

Ok, seems to join fine

@drcrallen drcrallen reopened this May 1, 2015
fjy added a commit that referenced this pull request May 1, 2015
@fjy
Merge pull request #1331 from metamx/fixIrcFirehoseNameNick
f734471 
fix IRCFirehoseFactory json name/nick mismatch
@fjy fjy merged commit f734471 into apache:master May 1, 2015
@fjy fjy deleted the fixIrcFirehoseNameNick branch May 1, 2015 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drcrallen @fjy