Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.3][EventDispatcher] make listeners removable from an executed listener #14633

Merged
merged 1 commit into from May 14, 2015

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented May 14, 2015

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #13972
License MIT
Doc PR

This fixes #13972 for Symfony 2.3. On Symfony 2.6 and higher, this has already been fixed with #14355.

@xabbuh xabbuh force-pushed the issue-13972-2.3 branch 2 times, most recently from bd37049 to 749ca40 Compare May 14, 2015 12:07
@xabbuh xabbuh changed the title [EventDispatcher] make listeners removable from an executed listener [2.3][EventDispatcher] make listeners removable from an executed listener May 14, 2015
@@ -12,6 +12,7 @@
namespace Symfony\Component\HttpKernel\Tests\Debug;

use Symfony\Component\EventDispatcher\EventDispatcher;
use Symfony\Component\EventDispatcher\EventDispatcherInterface;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is not needed AFAICS

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed

@fabpot
Copy link
Member

fabpot commented May 14, 2015

Thank you @xabbuh.

@fabpot fabpot merged commit 54bb399 into symfony:2.3 May 14, 2015
fabpot added a commit that referenced this pull request May 14, 2015
…ecuted listener (xabbuh)

This PR was merged into the 2.3 branch.

Discussion
----------

[2.3][EventDispatcher] make listeners removable from an executed listener

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #13972
| License       | MIT
| Doc PR        |

This fixes #13972 for Symfony 2.3. On Symfony 2.6 and higher, this has already been fixed with #14355.

Commits
-------

54bb399 [EventDispatcher] make listeners removable from an executed listener
@xabbuh xabbuh deleted the issue-13972-2.3 branch May 14, 2015 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants